Re: [PATCH v2 4/4] gpio: davinci: Add ti,tda54-gpio compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] gpio: davinci: missing IRQ flow handler update for level-triggered unbanked IRQs
--

commit 8228d1919a6fb52d7ab9246eaa1447341a319a9f
Author: Aniket Limaye <a-limaye@ti.com>

gpio: davinci: Add ti,tda54-gpio compatible
    
Add the ti,tda54-gpio compatible with extended registers for
level-triggered interrupt support.

> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 8d0ebf4afd169..db1f722693e0e 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -535,6 +535,11 @@ static const struct davinci_gpio_match_data keystone_gpio_data = {
>  	.get_irq_chip = keystone_gpio_get_irq_chip,
>  };
>  
> +static const struct davinci_gpio_match_data tda54_gpio_data = {
> +	.get_irq_chip = keystone_gpio_get_irq_chip,
> +	.ext_reg = true,

[Severity: High]
Does enabling extended registers for level-triggered interrupts here result
in missing flow handler updates for unbanked interrupts?

For unbanked interrupts, the driver overrides the parent irqchip's
.irq_set_type with gpio_irq_type_unbanked(). While this function configures
the local GPIO hardware for level triggers when g_ext is available:

drivers/gpio/gpio-davinci.c:gpio_irq_type_unbanked() {
	...
	if (g_ext) {
		writel_relaxed(mask, (trigger & IRQ_TYPE_LEVEL_HIGH)
			       ? &g_ext->set_high : &g_ext->clr_high);
		writel_relaxed(mask, (trigger & IRQ_TYPE_LEVEL_LOW)
			       ? &g_ext->set_low : &g_ext->clr_low);
	}

	return 0;
}

It returns 0 without calling the parent's .irq_set_type callback or
dynamically updating the flow handler (e.g., via irq_set_handler_locked()).

Will this cause the parent interrupt controller and the logical IRQ flow
handler to remain configured for default edge triggers, potentially leading
to mishandled level interrupts?

> +};
> +
>  static const struct of_device_id davinci_gpio_ids[];

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-upstream-tda54-gpio-v2-0-5c4f8b10cdbc@ti.com?part=4