Re: [PATCH] gpio: pca953x: Add support for MaxLinear's XRA1200 / XRA1200P

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] gpio: pca953x: missing PCA_INT flag for xra1200/xra1200p in pca953x_id
--

commit 79260b2b7ac0a0bff8a0c5399da85adabe336338
Author: Uwe Kleine-König <ukleinek@debian.org>

gpio: pca953x: Add support for MaxLinear's XRA1200 / XRA1200P

This commit adds I2C device ID and OF match table entries to support the
MaxLinear XRA1200 and XRA1200P 8-bit I2C GPIO expanders in the pca953x
driver.

> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index afec5ec236968..ea01fd152ac22 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -124,6 +124,8 @@ static const struct i2c_device_id pca953x_id[] = {
>  	{ .name = "tca9538", .driver_data = 8  | PCA953X_TYPE | PCA_INT },
>  	{ .name = "tca9539", .driver_data = 16 | PCA953X_TYPE | PCA_INT },
>  	{ .name = "tca9554", .driver_data = 8  | PCA953X_TYPE | PCA_INT },
> +	{ .name = "xra1200", .driver_data = 8  | PCA953X_TYPE },
> +	{ .name = "xra1200p", .driver_data = 8  | PCA953X_TYPE },

[Severity: Medium]
Should the xra1200 and xra1200p entries in pca953x_id[] in
drivers/gpio/gpio-pca953x.c also include the PCA_INT flag in .driver_data?

In pca953x_dt_ids[], the corresponding entries for these devices set PCA_INT,
matching the pca9534 and pca9554 entries that they are compatible with:

	{ .compatible = "maxlinear,xra1200",  .data = OF_953X( 8, PCA_INT), },
	{ .compatible = "maxlinear,xra1200p", .data = OF_953X( 8, PCA_INT), },

However, when an xra1200 or xra1200p device is matched via pca953x_id[] in
pca953x_probe() -> i2c_get_match_data(), chip->driver_data will not have
PCA_INT set, causing pca953x_irq_setup() to return early without setting up
interrupt support:

	if (!(chip->driver_data & PCA_INT))
		return 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261025154840.657888-2-ukleinek@debian.org?part=1