Re: [PATCH v3 09/22] gpio: Add missing OF module annotations

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] gpio: mpc5200: missing MODULE_DEVICE_TABLE() for mpc52xx_simple_gpiochip_match
--

commit 7d75c8390d5c804a0671444aa9096ad1c750b879
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

gpio: Add missing OF module annotations

This commit adds missing MODULE_DEVICE_TABLE(of, ...) declarations to several
GPIO drivers that match devices via Open Firmware device ID tables.

> diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c
> index 00f209157fd0f..2c828bc922ae3 100644
> --- a/drivers/gpio/gpio-mpc5200.c
> +++ b/drivers/gpio/gpio-mpc5200.c
> @@ -180,6 +180,7 @@ static const struct of_device_id mpc52xx_wkup_gpiochip_match[] = {
>  	{ .compatible = "fsl,mpc5200-gpio-wkup", },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, mpc52xx_wkup_gpiochip_match);

[Severity: Low]
Should mpc52xx_simple_gpiochip_match in drivers/gpio/gpio-mpc5200.c also be
annotated with MODULE_DEVICE_TABLE(of, mpc52xx_simple_gpiochip_match)?

This file registers two platform drivers in mpc52xx_gpio_init() via
platform_register_drivers(): mpc52xx_wkup_gpiochip_driver and
mpc52xx_simple_gpiochip_driver:

static const struct of_device_id mpc52xx_simple_gpiochip_match[] = {
	{ .compatible = "fsl,mpc5200-gpio", },
	{}
};

static struct platform_driver mpc52xx_simple_gpiochip_driver = {
	.driver = {
		.name = "mpc5200-gpio",
		.of_match_table = mpc52xx_simple_gpiochip_match,
	},
	.probe = mpc52xx_simple_gpiochip_probe,
};

Without MODULE_DEVICE_TABLE(of, mpc52xx_simple_gpiochip_match), the module
metadata generated for drivers/gpio/gpio-mpc5200.c omits the OF modalias for
"fsl,mpc5200-gpio".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793030820.git.u.kleine-koenig@baylibre.com?part=9