From: sashiko-bot@kernel.org
To: "Taniya Das" <taniya.das@oss.qualcomm.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 11/12] arm64: dts: qcom: sc7280: Add GP M/N clock controller
Date: Tue, 27 Oct 2026 11:31:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-186456@kernel.org> (raw)
In-Reply-To: <20261026-b4-pdm_clk_gp_mnd_v2-v2-11-ff8e4bc8d567@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: sc7280: undocumented gp_mn pinctrl function in kodiak.dtsi
--
commit 6f351e80c2c30a91b38cd18e71e46fa837dba70a
Author: Taniya Das <taniya.das@oss.qualcomm.com>
arm64: dts: qcom: sc7280: Add GP M/N clock controller
This commit adds the GP M/N clock controller node and its corresponding
gpio60 pinctrl state to the SC7280 (Kodiak) device tree.
> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> index 8c7523602d271..de27a051ee3b0 100644
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
[ ... ]
> @@ -6653,6 +6667,13 @@ mi2s0_sclk: mi2s0-sclk-state {
> function = "mi2s0_sck";
> };
>
> + gp_mn_active: gp-mn-active-state {
> + pins = "gpio60";
> + function = "gp_mn";
> + drive-strength = <2>;
> + bias-disable;
> + };
[Severity: Low]
Does adding gp_mn_active with function = "gp_mn" in
arch/arm64/boot/dts/qcom/kodiak.dtsi cause a dtbs_check regression for SC7280
device trees?
While commit 3f5919ddb9c9 ("pinctrl: qcom: sc7280: Add gp_mn mux function")
added support for gp_mn to drivers/pinctrl/qcom/pinctrl-sc7280.c, the
function enum under qcom-sc7280-tlmm-state in
Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml still
omits gp_mn:
function:
description:
Specify the alternative function to be configured for the specified
pins.
enum: [ atest_char, atest_char0, atest_char1, atest_char2, atest_char3,
...
dp_lcd, edp_hot, edp_lcd, gcc_gp1, gcc_gp2, gcc_gp3,
gpio, host2wlan_sol, ibi_i3c, jitter_bist, lpass_slimbus,
Should gp_mn be added to the function enum in
Documentation/devicetree/bindings/pinctrl/qcom,sc7280-pinctrl.yaml first so
that validating DTB files including kodiak.dtsi does not fail schema checks?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261026-b4-pdm_clk_gp_mnd_v2-v2-0-ff8e4bc8d567@oss.qualcomm.com?part=11
next prev parent reply other threads:[~2026-10-27 11:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:29 [PATCH v2 00/12] clk: qcom: Add PDM GP_MN fractional clock divider driver and DT support Taniya Das
2026-10-26 11:29 ` [PATCH v2 01/12] dt-bindings: clock: qcom: Add bindings for PDM GP_MN clock divider Taniya Das
2026-10-27 11:31 ` sashiko-bot
2026-10-27 18:47 ` Krzysztof Kozlowski
2026-10-29 10:57 ` Taniya Das
2026-10-26 11:29 ` [PATCH v2 02/12] dt-bindings: clock: qcom: Add PDM XO4 divider clock IDs Taniya Das
2026-10-28 11:28 ` Krzysztof Kozlowski
2026-10-26 11:29 ` [PATCH v2 03/12] clk: qcom: Add a driver for PDM GP_MN fractional clock divider Taniya Das
2026-10-27 11:31 ` sashiko-bot
2026-10-26 11:29 ` [PATCH v2 04/12] clk: qcom: gcc: Add configurable PDM XO4 div clocks across targets Taniya Das
2026-10-26 15:04 ` Abel Vesa
2026-10-26 11:29 ` [PATCH v2 05/12] pinctrl: qcom: qcs8300: Add gp_mn mux function Taniya Das
2026-10-26 11:29 ` [PATCH v2 06/12] pinctrl: qcom: sa8775p: " Taniya Das
2026-10-26 11:29 ` [PATCH v2 07/12] pinctrl: qcom: sc7280: " Taniya Das
2026-10-26 11:29 ` [PATCH v2 08/12] pinctrl: qcom: qcs615: " Taniya Das
2026-10-28 15:32 ` Abel Vesa
2026-10-29 8:15 ` Konrad Dybcio
2026-10-26 11:29 ` [PATCH v2 09/12] arm64: dts: qcom: qcs8300: Add GP M/N clock controller Taniya Das
2026-10-27 11:31 ` sashiko-bot
2026-10-26 11:29 ` [PATCH v2 10/12] arm64: dts: qcom: sa8775p: " Taniya Das
2026-10-27 11:31 ` sashiko-bot
2026-10-26 11:29 ` [PATCH v2 11/12] arm64: dts: qcom: sc7280: " Taniya Das
2026-10-26 16:27 ` Abel Vesa
2026-10-27 11:31 ` sashiko-bot [this message]
2026-10-26 11:29 ` [PATCH v2 12/12] arm64: dts: qcom: qcs615: " Taniya Das
2026-10-26 16:27 ` Abel Vesa
2026-10-27 11:31 ` sashiko-bot
2026-10-28 9:44 ` [PATCH v2 00/12] clk: qcom: Add PDM GP_MN fractional clock divider driver and DT support Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-186456@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox