Re: [PATCH v3 01/11] dt-bindings: gpio: vf610: fix clock requirements per SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: gpio: vf610: unwieldy per-compatible conditionals in schema
--

commit ea7be1f0505474b900ce5dd27177e80fd2222683
Author: Peng Fan <peng.fan@nxp.com>

dt-bindings: gpio: vf610: fix clock requirements per SoC

This commit updates the gpio-vf610 device tree binding schema to enforce
SoC-specific clock requirements for VF610, i.MX7ULP, and i.MX8ULP (and its
derivatives) via conditional blocks in allOf.

> diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> index a31f64b6d40b4..d1d5315ee1648 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
> @@ -57,11 +57,13 @@ properties:
>      maxItems: 32
>  
>    clocks:
> +    minItems: 1
>      items:
>        - description: SoC GPIO clock
>        - description: SoC PORT clock
>  
>    clock-names:
> +    minItems: 1
>      items:
>        - const: gpio
>        - const: port
> @@ -117,6 +119,45 @@ allOf:
>            items:
>              - description: GPIO register base address
>  
> +  - if:
> +      properties:
> +        compatible:
> +          const: fsl,vf610-gpio
> +    then:
> +      properties:
> +        clocks: false
> +        clock-names: false
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx7ulp-gpio
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +        clock-names:
> +          minItems: 2
> +      required:
> +        - clocks
> +        - clock-names
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8ulp-gpio
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +        clock-names:
> +          maxItems: 1
> +      required:
> +        - clocks
> +        - clock-names

[Severity: Low]
As reported by Sashiko on v2 [1], this isn't a bug, but in
Documentation/devicetree/bindings/gpio/gpio-vf610.yaml, the fsl,imx8ulp-gpio
family (including fsl,imx93-gpio, fsl,imx94-gpio, and fsl,imx95-gpio) does
not share a compatible fallback with fsl,vf610-gpio or fsl,imx7ulp-gpio, and
almost every hardware resource property now differs across the variants:

Documentation/devicetree/bindings/gpio/gpio-vf610.yaml:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - fsl,vf610-gpio
              - fsl,imx7ulp-gpio
    then:
      properties:
        interrupts:
          maxItems: 1
        reg:
          items:
            - description: PORT register base address
            - description: GPIO register base address
    else:
      properties:
        interrupts:
          minItems: 2
        reg:
          items:
            - description: GPIO register base address

Along with reg (2 items on VF610/i.MX7ULP vs 1 item on i.MX8ULP) and
interrupts (1 item on VF610/i.MX7ULP vs 2 items on i.MX8ULP), clocks and
clock-names are disallowed on VF610, require 2 items on i.MX7ULP, and require
1 item on i.MX8ULP.

Rather than relaxing the top-level clocks and clock-names properties to
minItems: 1 and adding three more per-compatible if-then blocks in allOf,
would it be cleaner to split the fsl,imx8ulp-gpio binding into a separate
schema document?

[1] https://lore.kernel.org/r/20261103-gpio-vf610-fixes-v2-1-7c71fb36e184@nxp.com

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-gpio-vf610-fixes-v3-0-504e19de5ad5@nxp.com?part=1