From: sashiko-bot@kernel.org
To: "Prasanth Kumar Padarthi" <prasanth.padarthi10@gmail.com>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: aspeed: Use managed pinctrl registration
Date: Sat, 07 Nov 2026 01:29:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-202465@kernel.org> (raw)
In-Reply-To: <20261107012236.28069-1-prasanth.padarthi10@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] pinctrl: aspeed: missing Fixes trailer for unmanaged
pinctrl_register() leak
--
commit 31a2821a3adb8fc70b45a6dcb2edc40ec8684675
Author: Prasanth Kumar Padarthi <prasanth.padarthi10@gmail.com>
> pinctrl: aspeed: Use managed pinctrl registration
>
> The shared Aspeed probe helper registers its controller with
> pinctrl_register(), but does not unregister it on device unbind.
> The registration can therefore outlive device-managed data.
>
> Use devm_pinctrl_register() to ensure the controller is unregistered
> during device teardown.
>
> Signed-off-by: Prasanth Kumar Padarthi <prasanth.padarthi10@gmail.com>
[Severity: Low]
Should this include a Fixes tag for the commit that introduced the
unmanaged pinctrl_register() call in aspeed_pinctrl_probe()?
Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107012236.28069-1-prasanth.padarthi10@gmail.com?part=1
next prev parent reply other threads:[~2026-11-07 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 1:22 [PATCH] pinctrl: aspeed: Use managed pinctrl registration Prasanth Kumar Padarthi
2026-11-07 1:29 ` sashiko-bot [this message]
2026-11-09 2:50 ` Andrew Jeffery
2026-11-09 3:56 ` [PATCH v2] " Prasanth Kumar Padarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-202465@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=prasanth.padarthi10@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox