From: sashiko-bot@kernel.org
To: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 3/5] gpiolib: clear debounce period before the "requested" flag
Date: Mon, 09 Nov 2026 10:37:17 +0000 [thread overview]
Message-ID: <sashiko-outbox-204829@kernel.org> (raw)
In-Reply-To: <20261109-gpio-desc-flags-atomic-v2-3-c4c54b476628@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] gpiolib: missing Fixes trailer for gpiod_free_commit() debounce
race fix
--
commit 1841b5514ac5cdddcf5ae7cb26a7302861e4ac43
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> gpiolib: clear debounce period before the "requested" flag
>
> The debounce_period_us field is protected by the GPIOD_FLAG_REQUESTED
> flag, so it should be cleared before the flag, else it could potentially
> race with a new request.
>
> Suggested-by: Kent Gibson <warthog618@gmail.com>
> Closes: https://lore.kernel.org/all/20261105042905.GB8436@rigel/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
[Severity: Low]
This fixes the ordering where gpiod_free_commit() cleared
desc->debounce_period_us after clearing GPIOD_FLAG_REQUESTED. Should the
commit message include a Fixes tag?
Fixes: 81625f362497 ("gpio: cdev: go back to storing debounce period in the GPIO descriptor")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-gpio-desc-flags-atomic-v2-0-c4c54b476628@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-11-09 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 10:27 [PATCH v2 0/5] gpiolib: improve concurrent access to the flags field of struct gpio_desc Bartosz Golaszewski
2026-11-09 10:27 ` [PATCH v2 1/5] gpiolib: don't overwrite the entire flags field in gpiod_get_direction() Bartosz Golaszewski
2026-11-09 10:27 ` [PATCH v2 2/5] gpio: shared: use atomic set_bit() for descriptor flags Bartosz Golaszewski
2026-11-09 10:34 ` sashiko-bot
2026-11-09 10:27 ` [PATCH v2 3/5] gpiolib: clear debounce period before the "requested" flag Bartosz Golaszewski
2026-11-09 10:37 ` sashiko-bot [this message]
2026-11-09 10:27 ` [PATCH v2 4/5] gpiolib: don't overwrite the entire flags field in gpiod_free_commit() Bartosz Golaszewski
2026-11-09 10:32 ` sashiko-bot
2026-11-09 21:53 ` Andy Shevchenko
2026-11-10 8:54 ` Bartosz Golaszewski
2026-11-10 10:06 ` Andy Shevchenko
2026-11-10 11:05 ` Joshua Crofts
2026-11-09 10:27 ` [PATCH v2 5/5] gpio: cdev: don't overwrite the whole flags field when configuring lines Bartosz Golaszewski
2026-11-09 21:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204829@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=linux-gpio@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox