Re: [PATCH v14 01/14] dt-bindings: gpio: pl061: add Ambarella CV75 variant

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] dt-bindings: gpio: pl061: split incompatible
  ambarella,cv75-gpio schema
- [Low] dt-bindings: gpio: pl061: undocumented ambarella vendor prefix
--

commit 1c2d672e664996e2a994481958b71e50ae2d14df
Author: Long Zhao <longzhao@ambarella.com>

dt-bindings: gpio: pl061: add Ambarella CV75 variant

This commit adds the ambarella,cv75-gpio compatible string and its
required arm,primecell-periphid and gpio-ranges constraints to the ARM
PL061 GPIO binding schema.

> diff --git a/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml b/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
> index 4d970e55104bb..c22dd8a1d2c18 100644
> --- a/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
> @@ -15,7 +15,9 @@ select:
>    properties:
>      compatible:
>        contains:
> -        const: arm,pl061
> +        enum:
> +          - arm,pl061
> +          - ambarella,cv75-gpio
>    required:
>      - compatible
>  
> @@ -25,7 +27,9 @@ properties:
>  
>    compatible:
>      items:
> -      - const: arm,pl061
> +      - enum:
> +          - ambarella,cv75-gpio
> +          - arm,pl061
>        - const: arm,primecell

[Severity: Low]
As reported by Krzysztof Kozlowski on v1 [1], is the ambarella vendor
prefix documented in Documentation/devicetree/bindings/vendor-prefixes.yaml?
Using ambarella,cv75-gpio without a matching vendor-prefixes.yaml entry
triggers checkpatch (UNDOCUMENTED_DT_STRING) and dt_binding_check
warnings.

>  
>    reg:
> @@ -64,6 +68,21 @@ required:
>    - "#gpio-cells"
>    - gpio-controller
>  
> -additionalProperties: false
> +allOf:
> +  - $ref: /schemas/arm/primecell.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ambarella,cv75-gpio
> +    then:
> +      properties:
> +        arm,primecell-periphid:
> +          const: 0x000e8061
> +      required:
> +        - arm,primecell-periphid
> +        - gpio-ranges
> +
> +unevaluatedProperties: false

[Severity: Medium]
Should ambarella,cv75-gpio be split into its own binding schema instead of
adding variant conditionals to pl061-gpio.yaml?

The CV75 controller has 32 lines per bank, adds extra registers, is not
register-compatible with the 8-line ARM PL061, and does not implement the
PL061 PrimeCell ID in hardware. Keeping it in pl061-gpio.yaml subjects a
32-line bank (where gpio-ranges is required) to the 8-line PL061 limits of
maxItems: 8 on both gpio-ranges and interrupts, causing dtbs_check
failures if a bank needs more than 8 disjoint ranges or interrupts.

[1] https://lore.kernel.org/r/a8b0729c-d6ff-4fa0-955e-deb0af0e726b@kernel.org

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-cv75-gpio-v14-0-e586aad0467a@ambarella.com?part=1