Re: [PATCH 04/10] pinctrl: nuvoton: ma35: Avoid leaking map when parent node is missing

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] pinctrl: nuvoton: ma35: inaccurate commit description of
  3fd976afe974
--

commit 16d0fceb87809d6ff503501ddb36d785b4f12a75
Author: Lee Jones <lee@kernel.org>

pinctrl: nuvoton: ma35: Avoid leaking map when parent node is missing

This commit moves the parent device node lookup before allocating new_map in
ma35_pinctrl_dt_node_to_map_func() so that new_map is not leaked if
of_get_parent() returns NULL.

> Commit 3fd976afe974 ("pinctrl: nuvoton: fix a double free in
> ma35_pinctrl_dt_node_to_map_func()") removed the kfree(new_map) call on
> the !parent error path to avoid a double free, but left *map = new_map
> assigned before of_get_parent(np).

[Severity: Low]
Is this description of 3fd976afe974 ("pinctrl: nuvoton: fix a double free
in ma35_pinctrl_dt_node_to_map_func()") accurate?

There was never a kfree(new_map) call on the !parent error path.
3fd976afe974 ("pinctrl: nuvoton: fix a double free in
ma35_pinctrl_dt_node_to_map_func()") switched the allocation from
devm_kcalloc() to unmanaged kcalloc() without freeing new_map when
of_get_parent() fails.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111215256.1982044-1-lee@kernel.org?part=4