Re: [PATCH v2 10/10] gpio: shared: generalize most code to firmware nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] gpio: shared: define __free() fwnode in one statement in
  scan_property()
--

commit 78d07ba961e7635e708d83665d68a4604d21cd5c
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

gpio: shared: generalize most code to firmware nodes

This commit converts the device-tree scanning code in gpiolib-shared.c to
use generic fwnode APIs and guards the remaining OF-specific entry point
with CONFIG_OF.

> diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
> index 44af3bc1494e4..edd61d16f065f 100644
> --- a/drivers/gpio/gpiolib-shared.c
> +++ b/drivers/gpio/gpiolib-shared.c

[ ... ]

> @@ -131,157 +130,159 @@ static int gpio_shared_setup_reset_proxy(struct gpio_shared_entry *entry,

[ ... ]

> +	for (i = 0; i < count; i++) {
> +		struct fwnode_handle *fwnode __free(fwnode_handle) = NULL;
> +		char *con_id __free(kfree) = NULL;
>  
> -			ret = of_parse_phandle_with_args(curr, prop->name,
> -							 "#gpio-cells", i,
> +		ret = fwnode_property_get_reference_args(curr, propname,
> +							 "#gpio-cells", 0, i,
>  							 &args);
> -			if (ret)
> -				continue;
> +		if (ret)
> +			continue;
>  
> -			np = args.np;
> +		fwnode = args.fwnode;

[Severity: Low]
This isn't a bug, but fwnode is not used before
fwnode_property_get_reference_args() succeeds, so it can be defined and
initialized in a single statement as:

	struct fwnode_handle *fwnode __free(fwnode_handle) = args.fwnode;

rather than being initialized to NULL at the top of the loop body and
assigned later.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-fwnode-for-each-prop-v2-0-4edc23d5cf50@oss.qualcomm.com?part=10