Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Prateek Agarwal" <praagarwal@nvidia.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 3/3] pinctrl: tegra: Add support for Tegra268
Date: Thu, 19 Nov 2026 07:09:45 +0000	[thread overview]
Message-ID: <sashiko-outbox-222543@kernel.org> (raw)
In-Reply-To: <20261119065249.2425224-4-praagarwal@nvidia.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] pinctrl: tegra: PIN_PINGROUP_ENTRY_Y hardcodes rcv_sel_bit to
  -1 on Tegra268
--

commit 504e6b9e2c6aa5bbd3e59fd78e4ff51426a7e008
Author: Prathamesh Shete <pshete@nvidia.com>

pinctrl: tegra: Add support for Tegra268

This commit adds the pinctrl driver for NVIDIA Tegra268 supporting the MAIN,
AON, and UPHY pin controllers.

> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra268.c b/drivers/pinctrl/tegra/pinctrl-tegra268.c
> new file mode 100644
> index 0000000000000..19f591061ec42
> --- /dev/null
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra268.c

[ ... ]

> +#define PIN_PINGROUP_ENTRY_Y(r, bank, pupd, e_io_hv, e_lpbk, e_input,	\
> +				e_lpdr, e_pbias_buf, gpio_sfio_sel,	\
> +				schmitt_b)				\
> +		.mux_reg = PINGROUP_REG_Y(r),			\
> +		.lpmd_bit = -1,					\
> +		.lock_bit = -1,					\
> +		.hsm_bit = -1,					\
> +		.odrain_bit = -1,				\
> +		.ioreset_bit = -1,				\
> +		.rcv_sel_bit = -1,				\

[Severity: Medium]
Should PIN_PINGROUP_ENTRY_Y set .rcv_sel_bit = e_io_hv instead of -1?

Every PINGROUP entry passes bit 5 for e_io_hv, and cfg_params[] in
drivers/pinctrl/tegra/pinctrl-tegra.c maps "nvidia,io-hv" to
TEGRA_PINCONF_PARAM_RCV_SEL, which tegra_pinconf_reg() resolves via
g->rcv_sel_bit.  Leaving .rcv_sel_bit hardcoded to -1 causes
tegra_pinconf_reg() to return -ENOTSUPP whenever a Device Tree uses
nvidia,io-hv.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119065249.2425224-1-praagarwal@nvidia.com?part=3

      reply	other threads:[~2026-11-19  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  6:52 [PATCH v3 0/3] Add Tegra268 pinmux support Prateek Agarwal
2026-11-19  6:52 ` [PATCH v3 1/3] soc/tegra: Add Tegra268 Kconfig symbol Prateek Agarwal
2026-11-19  6:52 ` [PATCH v3 2/3] dt-bindings: pinctrl: Document Tegra268 pin controllers Prateek Agarwal
2026-11-19  6:52 ` [PATCH v3 3/3] pinctrl: tegra: Add support for Tegra268 Prateek Agarwal
2026-11-19  7:09   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222543@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=praagarwal@nvidia.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox