Re: [PATCH V4 2/6] MIPS: Move Loongson GPIO driver to drivers/gpio

[陈华才 <chenhc@lemote.com>]

Hi, Ralf and Alexandre,

So, I need three patches: clean up, move to drivers/gpio, and improve it to support Loonson-3A/3B?

Huacai
 
 
------------------ Original ------------------
From:  "Ralf Baechle"<ralf@linux-mips.org>;
Date:  Wed, Nov 19, 2014 06:11 PM
To:  "Alexandre Courbot"<gnurou@gmail.com>;
Cc:  "Huacai Chen"<chenhc@lemote.com>; "John Crispin"<john@phrozen.org>; "Steven J. Hill"<Steven.Hill@imgtec.com>; "linux-mips"<linux-mips@linux-mips.org>; "Fuxin Zhang"<zhangfx@lemote.com>; "wuzhangjin"<wuzhangjin@gmail.com>; "linux-gpio@vger.kernel.org"<linux-gpio@vger.kernel.org>;
Subject:  Re: [PATCH V4 2/6] MIPS: Move Loongson GPIO driver to drivers/gpio
 
On Wed, Nov 19, 2014 at 05:21:56PM +0900, Alexandre Courbot wrote:

> > On Fri, Nov 14, 2014 at 12:12 AM, Huacai Chen <chenhc@lemote.com> wrote:
> >> Move Loongson-2's GPIO driver to drivers/gpio and add Kconfig options.
> >
> > Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> >
> > Guess this should go through the GPIO tree once the platform
> > maintainers have acked this?
> 
> Ouch. After looking at this driver's implementation I think I have to
> take my Ack back. This driver comes with custom definitions of
> gpio_get_value() and other functions, which we will want to get rid of
> before moving this into drivers/gpio. Can you port this to a proper
> gpiolib driver before doing the move?

As the arch maintainer I'm happy to say farewell to driver code in arch/mips.

Also, can we split the whole procedure into two patches, one for the cleanup
and one for the move?  I don't care in which order.

  Ralf