From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h Date: Wed, 29 Dec 2021 13:46:14 +0200 Message-ID: <081437ff-a69d-faf5-0981-389156a90668@nvidia.com> References: <20211229004913.513372-1-kuba@kernel.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h4Nym9iSieGcRP9Mc66kiluCyjNY8rcebbwh7mTxWaw=; b=XC/M3TZKS/h18UtS9kKeIzXFvrGIZAjXiMXIWJm4sWr976CNfhU0zEUEX/R/LFQMMb5RvoBLcsn6mD3DbHrTbQcg9AH4fb4esQ7utkAUE5LtUFYl6mUmDM7s6Z0q7RWCa0MasfYFORmA2kK3ZiRrtzkTJwuyUzBvQQNfWrvLDTLNK2iKsHRMCYgS8ox4/gAGDxxgUyqlf+nbMqPSzse/dtAMKlkxd8uvNx2RwtHQXyoEVmCAeCmIl6v3W5f7dvgWCd2ASnxoQlPhbcFiO7La9MVLuHILWjk8b4UXXPQqQrXa/lwrHG09PWd2VJbjqybd5pYk1qVSOuZnJlAsp3KKGw== Content-Language: en-US In-Reply-To: <20211229004913.513372-1-kuba@kernel.org> List-ID: Content-Type: text/plain; charset="us-ascii" To: Jakub Kicinski , ast@kernel.org, daniel@iogearbox.net Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, Marc Kleine-Budde , marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, dledford@redhat.com, jgg@ziepe.ca, mustafa.ismail@intel.com, shiraz.saleem@intel.com, leon@kernel.org, ap420073@gmail.com, wg@grandegger.com, woojung.huh@microchip.com, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, george.mccollister@gmail.com, michael.chan@broadcom.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, hawk@kernel.org, john.fastabend@gmail.com, tariqt@nvidia.com, saeedm@nvidia.com, ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com, jreuter@yaina.de, dsahern@kernel.org, kvalo@codeaurora.org, pkshih@realtek.com On 29/12/2021 02:49, Jakub Kicinski wrote: > sock.h is pretty heavily used (5k objects rebuilt on x86 after > it's touched). We can drop the include of filter.h from it and > add a forward declaration of struct sk_filter instead. > This decreases the number of rebuilt objects when bpf.h > is touched from ~5k to ~1k. > > There's a lot of missing includes this was masking. Primarily > in networking tho, this time. > > Acked-by: Marc Kleine-Budde > Signed-off-by: Jakub Kicinski > --- > v2: https://lore.kernel.org/all/20211228192519.386913-1-kuba@kernel.org/ > - fix build in bond on ia64 > - fix build in ip6_fib with randconfig > > CC: marcel@holtmann.org > CC: johan.hedberg@gmail.com > CC: luiz.dentz@gmail.com > CC: dledford@redhat.com > CC: jgg@ziepe.ca > CC: mustafa.ismail@intel.com > CC: shiraz.saleem@intel.com > CC: leon@kernel.org > CC: ap420073@gmail.com > CC: wg@grandegger.com > CC: woojung.huh@microchip.com > CC: andrew@lunn.ch > CC: vivien.didelot@gmail.com > CC: f.fainelli@gmail.com > CC: olteanv@gmail.com > CC: george.mccollister@gmail.com > CC: michael.chan@broadcom.com > CC: jesse.brandeburg@intel.com > CC: anthony.l.nguyen@intel.com > CC: ast@kernel.org > CC: daniel@iogearbox.net > CC: hawk@kernel.org > CC: john.fastabend@gmail.com > CC: tariqt@nvidia.com > CC: saeedm@nvidia.com > CC: ecree.xilinx@gmail.com > CC: habetsm.xilinx@gmail.com > CC: jreuter@yaina.de > CC: dsahern@kernel.org > CC: kvalo@codeaurora.org > CC: pkshih@realtek.com > CC: trond.myklebust@hammerspace.com > CC: anna.schumaker@netapp.com > CC: viro@zeniv.linux.org.uk > CC: andrii@kernel.org > CC: mcgrof@kernel.org > CC: keescook@chromium.org > CC: yzaikin@google.com > CC: nikolay@nvidia.com > CC: jiri@nvidia.com > CC: wintera@linux.ibm.com > CC: wenjia@linux.ibm.com > CC: pablo@netfilter.org > CC: kadlec@netfilter.org > CC: fw@strlen.de > CC: ralf@linux-mips.org > CC: jhs@mojatatu.com > CC: xiyou.wangcong@gmail.com > CC: kgraul@linux.ibm.com > CC: sgarzare@redhat.com > CC: steffen.klassert@secunet.com > CC: herbert@gondor.apana.org.au > CC: arnd@arndb.de > CC: linux-bluetooth@vger.kernel.org > CC: linux-rdma@vger.kernel.org > CC: linux-can@vger.kernel.org > CC: intel-wired-lan@lists.osuosl.org > CC: bpf@vger.kernel.org > CC: linux-hams@vger.kernel.org > CC: ath11k@lists.infradead.org > CC: linux-wireless@vger.kernel.org > CC: linux-nfs@vger.kernel.org > CC: linux-fsdevel@vger.kernel.org > CC: bridge@lists.linux-foundation.org > CC: linux-decnet-user@lists.sourceforge.net > CC: linux-s390@vger.kernel.org > CC: netfilter-devel@vger.kernel.org > CC: coreteam@netfilter.org > CC: virtualization@lists.linux-foundation.org > --- [snip] > net/bridge/br_ioctl.c | 1 + [snip > 70 files changed, 80 insertions(+), 1 deletion(-) > For the bridge: Acked-by: Nikolay Aleksandrov