From: Ralf Baechle DO1GRB <ralf@linux-mips.org>
To: Steve Whitehouse <Steve@ChyGwyn.com>
Cc: M Taylor <mctylr@privacy.nb.ca>, linux-hams@vger.kernel.org
Subject: Re: AX.25 in kernel 2.5 status?
Date: Fri, 11 Oct 2002 17:38:50 +0200 [thread overview]
Message-ID: <20021011173850.A19593@linux-mips.org> (raw)
In-Reply-To: <200210111456.PAA20991@gw.chygwyn.com>; from steve@gw.chygwyn.com on Fri, Oct 11, 2002 at 03:56:23PM +0100
On Fri, Oct 11, 2002 at 03:56:23PM +0100, Steven Whitehouse wrote:
> > Another problem we still have - and we're sharing it with other protocols
> > such ipv4 - is that our proc code is holding a lock for the time the
> > /proc file is open. That's not a significant time but it may delay
> > access, so I've made most of those loads rw locks. Worst case a buggy
> > or malicious piece of software might even hold a proc file open for a long
> > time thereby stalling the functioning of the stack partially or fully.
> >
> Its only during read operations, not the open that the lock is held I
> think, but I agree that an rw lock is the best solution here.
The only solution I see would be redoing the data structures or as
implemented in a few other places in the kernel accepting O(n) behaviour
for the seq_operations.next method - which would make reading the
performance for reading the proc file O(n^2). But that's a minor
problem at the moment.
73 de DO1GRB op Ralf
--
Loc. JN47BS / CQ 14 / ITU 28 / DOK A21
prev parent reply other threads:[~2002-10-11 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-10 2:57 AX.25 in kernel 2.5 status? M Taylor
2002-10-10 17:22 ` Ralf Baechle DO1GRB
2002-10-11 9:49 ` Steven Whitehouse
2002-10-11 13:03 ` Ralf Baechle DO1GRB
2002-10-11 13:47 ` Steven Whitehouse
2002-10-11 14:35 ` Ralf Baechle DO1GRB
2002-10-11 14:56 ` Steven Whitehouse
2002-10-11 15:38 ` Ralf Baechle DO1GRB [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021011173850.A19593@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steve@ChyGwyn.com \
--cc=linux-hams@vger.kernel.org \
--cc=mctylr@privacy.nb.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox