From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Art Haas <ahaas@airmail.net>
Cc: linux-net@vger.kernel.org, linux-hams@vger.kernel.org
Subject: Re: [PATCH] C99 initializers for net/netrom/sysctl_net_netrom.c
Date: Fri, 14 Feb 2003 00:19:25 -0200 [thread overview]
Message-ID: <20030214021925.GF6258@conectiva.com.br> (raw)
In-Reply-To: <20030214012320.GB13561@debian>
Em Thu, Feb 13, 2003 at 07:23:20PM -0600, Art Haas escreveu:
> Hi.
>
> Here's a patch that switches the file to use C99 initiailzers to aid
> readability and remove warings if '-W' is used.
>
> + .extra1 = &min_quality,
> + .extra2 = &max_quality
Art, just a small nitpick: the "standard" in the kernel sources is for all
the members to have an ending comma, just like this:
> + .extra1 = &min_quality,
> + .extra2 = &max_quality,
^
^
^
So that when we need to add another member the patch gets smaller 8)
Aside from this small nitpick, keep it up the good work!
- Arnaldo
prev parent reply other threads:[~2003-02-14 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-14 1:23 [PATCH] C99 initializers for net/netrom/sysctl_net_netrom.c Art Haas
2003-02-14 2:19 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030214021925.GF6258@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=ahaas@airmail.net \
--cc=linux-hams@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox