From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Jeroen Vreeken <pe1rxq@amsat.org>
Cc: linux-hams@vger.kernel.org, ralf@linux-mips.org
Subject: Re: [PATCH] ax25_cb refcounting & waitqueue usage
Date: Mon, 7 Jul 2003 10:37:10 -0300 [thread overview]
Message-ID: <20030707133710.GJ1820@conectiva.com.br> (raw)
In-Reply-To: <20030706192734.E4454@jeroen.pe1rxq.ampr.org>
Em Sun, Jul 06, 2003 at 07:27:34PM +0200, Jeroen Vreeken escreveu:
> Hi,
>
> Second patch for this weekend...
> This patch does two things, it adds reference counting to the ax25_cb
> structure (until now only the ax25_cb list was protected, not the parts
> using it) and it fixes an oops on interrupted socket syscalls. (e.g.
> pressing Ctrl-C while in the connect function) The waitqueue was not
> removed from the list and caused an oops in the socket release.
>
> I have had only a quick look at Steven's patch but I don't think the two
> will clash...
Hey, why not use sk->refcnt by means of sock_hold/sock_put? Current sources
even do that implicitely when you do a sk_add_node (sock_hold) and a
sk_del_node{_init} (sock_put)... Now it is just a matter of doing a sock_hold
when searching in some list and then dropping the refcnt when done using the
sock returned by the search function.
- Arnaldo
next prev parent reply other threads:[~2003-07-07 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-06 17:27 [PATCH] ax25_cb refcounting & waitqueue usage Jeroen Vreeken
2003-07-07 13:37 ` Arnaldo Carvalho de Melo [this message]
2003-07-07 17:23 ` Jeroen Vreeken
2003-07-07 17:25 ` Arnaldo Carvalho de Melo
2003-07-08 22:52 ` Jeroen Vreeken
2003-07-09 17:06 ` Jeroen Vreeken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030707133710.GJ1820@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=linux-hams@vger.kernel.org \
--cc=pe1rxq@amsat.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox