From: Ralf Baechle DO1GRB <ralf@linux-mips.org>
To: Jeroen Vreeken <pe1rxq@amsat.org>
Cc: linux-hams@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH] scc fix for 2.6.0
Date: Sat, 27 Dec 2003 05:05:23 +0100 [thread overview]
Message-ID: <20031227040522.GA7123@linux-mips.org> (raw)
In-Reply-To: <20031225195233.C3614@jeroen.pe1rxq.ampr.org>
On Thu, Dec 25, 2003 at 07:52:33PM +0100, Jeroen Vreeken wrote:
> This is a fix for the scc driver in 2.6.0
> It was calling register_netdev from within a ioctl and thus holding
> rtnl_lock()
> It now uses register_netdevice and calls rtnl_lock() itself if outside the
> ioctl.
Somehow the whole device registration in that driver looks suspect.
Registering from the driver's module_init() method is fine - but doing so
from ioctl looks more it's some kind of ancient workaround or so?
73 de DO1GRB op Ralf
--
Loc. JN47BS / CQ 14 / ITU 28 / DOK A21
next prev parent reply other threads:[~2003-12-27 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-25 18:52 [PATCH] scc fix for 2.6.0 Jeroen Vreeken
2003-12-26 10:28 ` Re : " Jean-Luc Coulon (f5ibh)
2003-12-27 4:05 ` Ralf Baechle DO1GRB [this message]
2003-12-30 18:41 ` Jeroen Vreeken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031227040522.GA7123@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jgarzik@pobox.com \
--cc=linux-hams@vger.kernel.org \
--cc=pe1rxq@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox