From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [PATCH] Fix ax25_get_socket locking Date: Mon, 14 Mar 2005 21:30:15 -0800 Message-ID: <20050314213015.1b113610.davem@davemloft.net> References: <20050314083744.GA12765@linux-mips.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit In-Reply-To: <20050314083744.GA12765@linux-mips.org> Sender: linux-hams-owner@vger.kernel.org List-Id: Content-Type: text/plain; charset="us-ascii" To: Ralf Baechle DL5RB Cc: netdev@oss.sgi.com, linux-hams@vger.kernel.org On Mon, 14 Mar 2005 08:37:44 +0000 Ralf Baechle DL5RB wrote: > In an attempt to return a locked socket ax25_get_socket() was calling > lock_sock() with a spinlock held, bad idea. Making matters worse it's > only user is running in bottom half context resulting in a potencial > attempt to sleep in bottom half context, so fix the locking there as well. Looks fine. Applied, thanks Ralf.