2.6.15 ax25 system lockup with kissattach

2.6.15 ax25 system lockup with kissattach

[Mike McCarthy, W1NR]

I am using SuSE 10.0 with 2.6.15 kernel built from source or via SuSE kotd
rpm.  The system will hang when issuing kissattach command.

># /etc/ax25/ax25d.conf
>#
># ax25d Configuration File.
>#
># AX.25 Ports begin with a '['.
>#
>[W1NR VIA 2m]
>parameters      2 1 6 900 * 15 0
>NOCALL   * * * * * * L
>default  * * * * * * - root /spider/src/client client %s ax25

># /etc/ax25/axports
>#
># The format of this file is:
>#
># name callsign speed paclen window description
>#
>2m      W1NR-9          19200   255     2       145.650 MHz (1200 bps)


Following is a trace of commands issued:


>worf:~ # modprobe -v mkiss
>insmod /lib/modules/2.6.15-20060103193109-debug/kernel/lib/crc16.ko
>insmod /lib/modules/2.6.15-20060103193109-debug/kernel/net/ax25/ax25.ko
>insmod
/lib/modules/2.6.15-20060103193109-debug/kernel/drivers/net/hamradio/mkiss.k
o
>worf:~ # kissattach /dev/ttyS0 2m 44.56.10.3
>AX.25 port 2m bound to device ax0


That's all folks.  System locked up hard.  Caps lock and scroll lock lights
flashing.  System needs a hard reset.

2.6.14-5 appears to be fine.  Tried recompiled tools and libraries as well.
Others report similar problems on Debian systems with 2.6.15 kernel as well.

Mike McCarthy, W1NR

Re: 2.6.15 ax25 system lockup with kissattach

[Ralf Baechle DL5RB]

On Thu, Jan 05, 2006 at 06:26:43PM -0500, Mike McCarthy, W1NR wrote:

> >worf:~ # modprobe -v mkiss
> >insmod /lib/modules/2.6.15-20060103193109-debug/kernel/lib/crc16.ko
> >insmod /lib/modules/2.6.15-20060103193109-debug/kernel/net/ax25/ax25.ko
> >insmod
> /lib/modules/2.6.15-20060103193109-debug/kernel/drivers/net/hamradio/mkiss.k
> o
> >worf:~ # kissattach /dev/ttyS0 2m 44.56.10.3
> >AX.25 port 2m bound to device ax0
> 
> 
> That's all folks.  System locked up hard.  Caps lock and scroll lock lights
> flashing.  System needs a hard reset.
> 
> 2.6.14-5 appears to be fine.  Tried recompiled tools and libraries as well.
> Others report similar problems on Debian systems with 2.6.15 kernel as well.

Is this a preemptable and/or SMP kernel?

73 de DL5RB op Ralf

--
Loc. JN47BS / CQ 14 / ITU 28 / DOK A21

Re: 2.6.15 ax25 system lockup with kissattach

[Ralf Baechle DL5RB]

On Thu, Jan 05, 2006 at 06:26:43PM -0500, Mike McCarthy, W1NR wrote:

> That's all folks.  System locked up hard.  Caps lock and scroll lock lights
> flashing.  System needs a hard reset.
> 
> 2.6.14-5 appears to be fine.  Tried recompiled tools and libraries as well.
> Others report similar problems on Debian systems with 2.6.15 kernel as well.

Can you try below patch?  It fixes a locking bug which was affecting only
preemptable or SMP kernels until the recent rewrite of the locking code.

73 de DL5RB op Ralf

--
Loc. JN47BS / CQ 14 / ITU 28 / DOK A21

 drivers/net/hamradio/mkiss.c |    1 +
 1 files changed, 1 insertion(+)

Index: net.git/drivers/net/hamradio/mkiss.c
===================================================================
--- net.git.orig/drivers/net/hamradio/mkiss.c
+++ net.git/drivers/net/hamradio/mkiss.c
@@ -515,6 +515,7 @@ static void ax_encaps(struct net_device 
 			count = kiss_esc(p, (unsigned char *)ax->xbuff, len);
 		}
   	}
+	spin_unlock_bh(&ax->buflock);
 
 	set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags);
 	actual = ax->tty->driver->write(ax->tty, ax->xbuff, count);

Re: 2.6.15 ax25 system lockup with kissattach

[Markus Roch]

Hi,

I've inserted "spin_unlock_bh(&ax->buflock);" from Ralf's patch
to mkiss.c and recompiled the kernel and modules and now everything
ist working again under 2.6.15 :-)

Thanks
73 de Markus, DL2KMR


Zitat von Ralf Baechle DL5RB <ralf@linux-mips.org>:

> On Thu, Jan 05, 2006 at 06:26:43PM -0500, Mike McCarthy, W1NR wrote:
>
>> That's all folks.  System locked up hard.  Caps lock and scroll lock lights
>> flashing.  System needs a hard reset.
>>
>> 2.6.14-5 appears to be fine.  Tried recompiled tools and libraries as well.
>> Others report similar problems on Debian systems with 2.6.15 kernel as well.
>
> Can you try below patch?  It fixes a locking bug which was affecting only
> preemptable or SMP kernels until the recent rewrite of the locking code.
>
> 73 de DL5RB op Ralf
>
> --
> Loc. JN47BS / CQ 14 / ITU 28 / DOK A21
>
> drivers/net/hamradio/mkiss.c |    1 +
> 1 files changed, 1 insertion(+)
>
> Index: net.git/drivers/net/hamradio/mkiss.c
> ===================================================================
> --- net.git.orig/drivers/net/hamradio/mkiss.c
> +++ net.git/drivers/net/hamradio/mkiss.c
> @@ -515,6 +515,7 @@ static void ax_encaps(struct net_device
> 			count = kiss_esc(p, (unsigned char *)ax->xbuff, len);
> 		}
>   	}
> +	spin_unlock_bh(&ax->buflock);
>
> 	set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags);
> 	actual = ax->tty->driver->write(ax->tty, ax->xbuff, count);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-hams" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

RE: 2.6.15 ax25 system lockup with kissattach

[Mike McCarthy, W1NR]

Hi Ralf,
   It appears that the patch to mkiss.c fixes the lockup issue.  I have
external modem issues that prevents me from testing further at the moment.
I hope to have an RF test network set up and running by tomorrow to give it
a complete test.

Thanks for the very quick action and 73,
Mike, W1NR

-----Original Message-----
From: linux-hams-owner@vger.kernel.org
[mailto:linux-hams-owner@vger.kernel.org] On Behalf Of Markus Roch
Sent: Saturday, January 07, 2006 7:51 AM
To: Ralf Baechle DL5RB
Cc: linux-hams@vger.kernel.org
Subject: Re: 2.6.15 ax25 system lockup with kissattach

Hi,

I've inserted "spin_unlock_bh(&ax->buflock);" from Ralf's patch to mkiss.c
and recompiled the kernel and modules and now everything ist working again
under 2.6.15 :-)

Thanks
73 de Markus, DL2KMR


Zitat von Ralf Baechle DL5RB <ralf@linux-mips.org>:

> On Thu, Jan 05, 2006 at 06:26:43PM -0500, Mike McCarthy, W1NR wrote:
>
>> That's all folks.  System locked up hard.  Caps lock and scroll lock 
>> lights flashing.  System needs a hard reset.
>>
>> 2.6.14-5 appears to be fine.  Tried recompiled tools and libraries as
well.
>> Others report similar problems on Debian systems with 2.6.15 kernel as
well.
>
> Can you try below patch?  It fixes a locking bug which was affecting 
> only preemptable or SMP kernels until the recent rewrite of the locking
code.
>
> 73 de DL5RB op Ralf
>
> --
> Loc. JN47BS / CQ 14 / ITU 28 / DOK A21
>
> drivers/net/hamradio/mkiss.c |    1 +
> 1 files changed, 1 insertion(+)
>
> Index: net.git/drivers/net/hamradio/mkiss.c
> ===================================================================
> --- net.git.orig/drivers/net/hamradio/mkiss.c
> +++ net.git/drivers/net/hamradio/mkiss.c
> @@ -515,6 +515,7 @@ static void ax_encaps(struct net_device
> 			count = kiss_esc(p, (unsigned char *)ax->xbuff,
len);
> 		}
>   	}
> +	spin_unlock_bh(&ax->buflock);
>
> 	set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags);
> 	actual = ax->tty->driver->write(ax->tty, ax->xbuff, count);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-hams" 
> in the body of a message to majordomo@vger.kernel.org More majordomo 
> info at  http://vger.kernel.org/majordomo-info.html
>



-
To unsubscribe from this list: send the line "unsubscribe linux-hams" in the
body of a message to majordomo@vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html

Linux FPAC MINI-HOWTO

[bernard f6bvp]

Hi,

I have written a Linux FPAC MINI-HOWTO to help setting an X.25 PLP 
(rose) node station from scratch based on my own implementation.
The document covers  step by step the way to set up a node packet-radio 
station based on a Mandriva Linux 2006 distro with 2.6.14-4 kernel.
The different chapters are :

   1. Have a Linux 2.6-14-4 kernel with AX25 modules
   2. Install AX25 libraries
   3. Install AX25 tools
   4. Install AX25 applications
   5. Configure ax25ipd daemon
   6. Install FPAC software
   7. Install AX25 starting scripts

Links point toward libax25, ax25tools, ax25apps, fpac327 packages that I 
slightly modified (include headers) to allow smooth compilation with 2.6 
kernels.
Packages include recent advances with ax25ipd including dynamic IP and 
af_rose.c patch for alternate rose search.

Here is the URL : http://rose.fpac.free.fr/MINI-HOWTO/
Also available in french language http://rose.fpac.free.fr/MINI-HOWTO-FR/

73 de Bernard, f6bvp

Re: 2.6.15 ax25 system lockup with kissattach

[Bob Nielsen]

2.6.15 with the patch looks good here on my DX Spider node.

73,
Bob, N7XY

On Jan 6, 2006, at 4:42 PM, Ralf Baechle DL5RB wrote:

> On Thu, Jan 05, 2006 at 06:26:43PM -0500, Mike McCarthy, W1NR wrote:
>
>> That's all folks.  System locked up hard.  Caps lock and scroll  
>> lock lights
>> flashing.  System needs a hard reset.
>>
>> 2.6.14-5 appears to be fine.  Tried recompiled tools and libraries  
>> as well.
>> Others report similar problems on Debian systems with 2.6.15  
>> kernel as well.
>
> Can you try below patch?  It fixes a locking bug which was  
> affecting only
> preemptable or SMP kernels until the recent rewrite of the locking  
> code.
>
> 73 de DL5RB op Ralf
>
> --
> Loc. JN47BS / CQ 14 / ITU 28 / DOK A21
>
>  drivers/net/hamradio/mkiss.c |    1 +
>  1 files changed, 1 insertion(+)
>
> Index: net.git/drivers/net/hamradio/mkiss.c
> ===================================================================
> --- net.git.orig/drivers/net/hamradio/mkiss.c
> +++ net.git/drivers/net/hamradio/mkiss.c
> @@ -515,6 +515,7 @@ static void ax_encaps(struct net_device
>  			count = kiss_esc(p, (unsigned char *)ax->xbuff, len);
>  		}
>    	}
> +	spin_unlock_bh(&ax->buflock);
>
>  	set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags);
>  	actual = ax->tty->driver->write(ax->tty, ax->xbuff, count);
> -
> To unsubscribe from this list: send the line "unsubscribe linux- 
> hams" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: 2.6.15 ax25 system lockup with kissattach

[Bernard Pidoux]

Hi Ralf,

Without your patch, running Mandriva Linux 2006 with 2.6.15 kernel on a 
Pentium IV Xeon would freeze immediately when loading mkiss driver.

After the patch was applied and mkiss module compiled and driver 
installed, there is no more problem here.

However, the kernel was compiled with no forced preemption model and 
without SMP option. I will do it soon an report if any change.

Thank you for the nice job you are doing on AX25 stuff.

73 de Bernard, f6bvp

http://f6bvp.free
http://f6bvp.org (mirror)

-----------

Ralf Baechle DL5RB a écrit :
> On Thu, Jan 05, 2006 at 06:26:43PM -0500, Mike McCarthy, W1NR wrote:
> 
> 
>>That's all folks.  System locked up hard.  Caps lock and scroll lock lights
>>flashing.  System needs a hard reset.
>>
>>2.6.14-5 appears to be fine.  Tried recompiled tools and libraries as well.
>>Others report similar problems on Debian systems with 2.6.15 kernel as well.
> 
> 
> Can you try below patch?  It fixes a locking bug which was affecting only
> preemptable or SMP kernels until the recent rewrite of the locking code.
> 
> 73 de DL5RB op Ralf
> 
> --
> Loc. JN47BS / CQ 14 / ITU 28 / DOK A21
> 
>  drivers/net/hamradio/mkiss.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> Index: net.git/drivers/net/hamradio/mkiss.c
> ===================================================================
> --- net.git.orig/drivers/net/hamradio/mkiss.c
> +++ net.git/drivers/net/hamradio/mkiss.c
> @@ -515,6 +515,7 @@ static void ax_encaps(struct net_device 
>  			count = kiss_esc(p, (unsigned char *)ax->xbuff, len);
>  		}
>    	}
> +	spin_unlock_bh(&ax->buflock);
>  
>  	set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags);
>  	actual = ax->tty->driver->write(ax->tty, ax->xbuff, count);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-hams" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

2.6.15 ax25 system lockup with kissattach

[Bob Brose N0QBJ]

Ralf,
You fix cured the 2.6.15 problem on PPC too, thanks! It was interesting though
that the behaviour was different before the patch. The machine didn't lock up,
it paniced.

Bob
-- 
/~\ The ASCII       | Robert E. Brose II    N0QBJ
\ / Ribbon Campaign | http://www.qbjnet.com/
 X  Help cure       | 
/ \ HTML Email      | public key at http://www.qbjnet.com/key.html