From: Ralf Baechle DL5RB <ralf@linux-mips.org>
To: Bernard Pidoux <pidoux@ccr.jussieu.fr>
Cc: linux-hams@vger.kernel.org
Subject: Re: ROSE lockup fix
Date: Wed, 18 Jan 2006 08:38:16 +0000 [thread overview]
Message-ID: <20060118083816.GA7510@linux-mips.org> (raw)
In-Reply-To: <20060118010843.GA3312@linux-mips.org>
On Wed, Jan 18, 2006 at 01:08:43AM +0000, Ralf Baechle DL5RB wrote:
> Anyway, the problem is pretty obvious in your traceback and I'll cook a
> patch for you to test.
Can you test the patch below?
Ralf
net/rose/rose_route.c | 7 -------
1 files changed, 7 deletions(-)
Index: linux-mips/net/rose/rose_route.c
===================================================================
--- linux-mips.orig/net/rose/rose_route.c
+++ linux-mips/net/rose/rose_route.c
@@ -48,8 +48,6 @@ static DEFINE_SPINLOCK(rose_route_list_l
struct rose_neigh *rose_loopback_neigh;
-static void rose_remove_neigh(struct rose_neigh *);
-
/*
* Add a new route to a node, and in the process add the node and the
* neighbour if it is new.
@@ -235,11 +233,8 @@ static void rose_remove_neigh(struct ros
skb_queue_purge(&rose_neigh->queue);
- spin_lock_bh(&rose_neigh_list_lock);
-
if ((s = rose_neigh_list) == rose_neigh) {
rose_neigh_list = rose_neigh->next;
- spin_unlock_bh(&rose_neigh_list_lock);
kfree(rose_neigh->digipeat);
kfree(rose_neigh);
return;
@@ -248,7 +243,6 @@ static void rose_remove_neigh(struct ros
while (s != NULL && s->next != NULL) {
if (s->next == rose_neigh) {
s->next = rose_neigh->next;
- spin_unlock_bh(&rose_neigh_list_lock);
kfree(rose_neigh->digipeat);
kfree(rose_neigh);
return;
@@ -256,7 +250,6 @@ static void rose_remove_neigh(struct ros
s = s->next;
}
- spin_unlock_bh(&rose_neigh_list_lock);
}
/*
next prev parent reply other threads:[~2006-01-18 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-11 17:45 AX25 patches and how it affects the end user Douglas Cole
2006-01-11 22:14 ` Mike McCarthy, W1NR
2006-01-12 0:55 ` Douglas Cole
2006-01-13 21:09 ` Ralf Baechle DL5RB
2006-01-17 16:59 ` Bernard Pidoux
2006-01-18 1:08 ` Ralf Baechle DL5RB
2006-01-18 8:38 ` Ralf Baechle DL5RB [this message]
2006-01-19 16:44 ` ROSE lockup fix Bernard Pidoux
2006-02-09 16:25 ` Bernard Pidoux
2006-01-18 12:26 ` AX25 patches and how it affects the end user Chuck Hast
2006-01-18 21:52 ` Ralf Baechle DL5RB
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118083816.GA7510@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-hams@vger.kernel.org \
--cc=pidoux@ccr.jussieu.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).