From: "David S. Miller" <davem@davemloft.net>
To: ralf@linux-mips.org
Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org
Subject: Re: [AX.25] Fix potencial memory hole.
Date: Sun, 19 Mar 2006 13:20:18 -0800 (PST) [thread overview]
Message-ID: <20060319.132018.80403704.davem@davemloft.net> (raw)
In-Reply-To: <20060319124246.GA6261@linux-mips.org>
From: Ralf Baechle DL5RB <ralf@linux-mips.org>
Date: Sun, 19 Mar 2006 12:42:46 +0000
> If the AX.25 dialect chosen by the sysadmin is set to DAMA master / 3
> (or DAMA slave / 2, if CONFIG_AX25_DAMA_SLAVE=n) ax25_kick() will fall
> through the switch statement without calling ax25_send_iframe() or any
> other function that would eventually free skbn thus leaking the packet.
>
> Fix by restricting the sysctl inferface to allow only actually supported
> AX.25 dialects.
>
> The system administration mistake needed for this to happen is rather
> unlikely, so this is an uncritical hole.
>
> Coverity #651.
>
> Signed-off-by: Ralf Baechle DL5RB <ralf@linux-mips.org>
Applied, thanks a lot Ralf.
prev parent reply other threads:[~2006-03-19 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 12:42 [AX.25] Fix potencial memory hole Ralf Baechle DL5RB
2006-03-19 21:20 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060319.132018.80403704.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).