From: Ralf Baechle DL5RB <ralf@linux-mips.org>
To: Laurent Wandrebeck <l.wandrebeck@free.fr>
Cc: linux-hams@vger.kernel.org
Subject: Re: [patch 1/1] request_region() return value missing check
Date: Sat, 29 Apr 2006 12:58:05 +0100 [thread overview]
Message-ID: <20060429115805.GA26183@linux-mips.org> (raw)
In-Reply-To: <200603171330.40614.l.wandrebeck@free.fr>
On Fri, Mar 17, 2006 at 01:30:40PM +0100, Laurent Wandrebeck wrote:
> Here is a simple patch against 2.6.16-rc6-git8.
> Is adds checks about return value for two request_region() in drivers/net/hamradio/scc.c.
Several things:
o Your mailer garbles patches, so I couldn't apply it anymore.
o If the second request_region your patches will abort initialization
leaving the first one region allocated.
o The potencial abort happens in a loop so if we abort anytime other than
during the first iteration the resources will stay allocated and the
driver won't drive instances found earlier.
Thanks,
Ralf
prev parent reply other threads:[~2006-04-29 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 12:30 [patch 1/1] request_region() return value missing check Laurent Wandrebeck
2006-04-29 11:58 ` Ralf Baechle DL5RB [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060429115805.GA26183@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=l.wandrebeck@free.fr \
--cc=linux-hams@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).