* [PATCH] Masking bug in 6pack driver?
@ 2006-11-23 17:58 Jean Delvare
2006-11-23 18:43 ` Ralf Baechle DL5RB
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2006-11-23 17:58 UTC (permalink / raw)
To: Andreas Koensgen; +Cc: linux-hams, Ralf Baechle
Looks like a broken masking to me, binary not is used where bitwise not
was intended.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/net/hamradio/6pack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.19-rc6.orig/drivers/net/hamradio/6pack.c 2006-09-21 21:27:38.000000000 +0200
+++ linux-2.6.19-rc6/drivers/net/hamradio/6pack.c 2006-11-23 18:46:37.000000000 +0100
@@ -914,7 +914,7 @@
printk(KERN_DEBUG "6pack: protocol violation\n");
else
sp->status = 0;
- cmd &= !SIXP_RX_DCD_MASK;
+ cmd &= ~SIXP_RX_DCD_MASK;
}
sp->status = cmd & SIXP_PRIO_DATA_MASK;
} else { /* output watchdog char if idle */
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Masking bug in 6pack driver?
2006-11-23 17:58 [PATCH] Masking bug in 6pack driver? Jean Delvare
@ 2006-11-23 18:43 ` Ralf Baechle DL5RB
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle DL5RB @ 2006-11-23 18:43 UTC (permalink / raw)
To: Jean Delvare; +Cc: Andreas Koensgen, linux-hams
On Thu, Nov 23, 2006 at 06:58:10PM +0100, Jean Delvare wrote:
> Looks like a broken masking to me, binary not is used where bitwise not
> was intended.
Amazing ...
Forwarded to upstream; with a bit of luck your fix will still make it
into 2.6.19.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-23 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-23 17:58 [PATCH] Masking bug in 6pack driver? Jean Delvare
2006-11-23 18:43 ` Ralf Baechle DL5RB
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).