Re: conversd-saupp-1.62a

[Thorsten Kranzkowski <dl8bcu@dl8bcu.de>]

On Fri, Feb 13, 2015 at 02:53:17PM +0000, Paul Lewis wrote:
> 
> Hello all

Hi Paul!

> I am trying to install conversd-saupp-1.62a.20090622.tar.gz
> on a new Ubuntu 14.4.1 system
> 
> and getting the following error. Anyone got any ideas how to over
> comethis.
> Still lot of warnings in the make, which I ignore as the binaries are
> created.
> 
> Just not able to create the directories and install the binaries using
> the following command.
> Anyone have a solution please - may apply to the make install-all as
> well
> 
> make install-bin
> gcc -O2 -s -Wall -Wstrict-prototypes -DWANT_LOG -DFORKPTY
> -DOWNER=\"daemon\" -DGID=\"daemon\"
> -DCONF_DIR=\"/usr/local/conversd-saupp/etc\"
> -DDATA_DIR=\"/usr/local/conversd-saupp/var\" -DCONVERSHOST=\"localhost\"
> -DSETLOGNAMES -DHAVE_LIBREADLINE -DHAVE_READLINE_READLINE_H \
>                 convers.c ba_stub.o -o convers -lreadline -lncurses
> convers.c: In function âdo_logâ:
> convers.c:255:3: warning: format not a string literal and no format
> arguments [-Wformat-security]
>    fprintf(stderr, fmt);

Strictly speaking, it'a a warning, not an error. But anyway, you need to
fix convers.c:

a) insert a line reading
	#include <stdarg.h>
   at the beginning (where the other includes are).

b) make the function do_log (around line 255) look like this:

	int do_log(int level, const char *fmt, ...) {
	  va_list argp;
	  if (level > 2)
		  return 0;
	  va_start(argp, fmt);
	  vfprintf(stderr, fmt, argp);
	  va_end(argp);
	  return fflush(stderr);
	}

 
This should do the trick.

73 Thorsten DL8BCU

> 73 de Paul G4APL
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hams" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
| Thorsten Kranzkowski        Internet: dl8bcu@dl8bcu.de                      |
| Mobile: ++49 170 1876134       Snail: Kiebitzstr. 14, 49324 Melle, Germany  |
| Ampr: dl8bcu@db0lj.#rpl.deu.eu, dl8bcu@marvin.dl8bcu.ampr.org [44.130.8.19] |
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html