* [PATCH 105/141] net: ax25: Fix fall-through warnings for Clang
[not found] <cover.1605896059.git.gustavoars@kernel.org>
@ 2020-11-20 18:37 ` Gustavo A. R. Silva
2021-03-04 22:54 ` Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 109/141] net: netrom: " Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 112/141] net: rose: " Gustavo A. R. Silva
2 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2020-11-20 18:37 UTC (permalink / raw)
To: Joerg Reuter, Ralf Baechle, David S. Miller, Jakub Kicinski
Cc: linux-hams, netdev, linux-kernel, linux-hardening,
Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/ax25/af_ax25.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index 269ee89d2c2b..2631efc6e359 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -850,6 +850,7 @@ static int ax25_create(struct net *net, struct socket *sock, int protocol,
case AX25_P_ROSE:
if (ax25_protocol_is_registered(AX25_P_ROSE))
return -ESOCKTNOSUPPORT;
+ break;
#endif
default:
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 109/141] net: netrom: Fix fall-through warnings for Clang
[not found] <cover.1605896059.git.gustavoars@kernel.org>
2020-11-20 18:37 ` [PATCH 105/141] net: ax25: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2020-11-20 18:38 ` Gustavo A. R. Silva
2020-11-30 12:51 ` Dan Carpenter
2020-11-20 18:38 ` [PATCH 112/141] net: rose: " Gustavo A. R. Silva
2 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2020-11-20 18:38 UTC (permalink / raw)
To: Ralf Baechle, David S. Miller, Jakub Kicinski
Cc: linux-hams, netdev, linux-kernel, linux-hardening,
Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/netrom/nr_route.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 78da5eab252a..de0456073dc0 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -266,6 +266,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
fallthrough;
case 2:
re_sort_routes(nr_node, 0, 1);
+ break;
case 1:
break;
}
@@ -359,6 +360,7 @@ static int nr_del_node(ax25_address *callsign, ax25_address *neighbour, struct n
fallthrough;
case 1:
nr_node->routes[1] = nr_node->routes[2];
+ fallthrough;
case 2:
break;
}
@@ -482,6 +484,7 @@ static int nr_dec_obs(void)
fallthrough;
case 1:
s->routes[1] = s->routes[2];
+ break;
case 2:
break;
}
@@ -529,6 +532,7 @@ void nr_rt_device_down(struct net_device *dev)
fallthrough;
case 1:
t->routes[1] = t->routes[2];
+ break;
case 2:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 112/141] net: rose: Fix fall-through warnings for Clang
[not found] <cover.1605896059.git.gustavoars@kernel.org>
2020-11-20 18:37 ` [PATCH 105/141] net: ax25: Fix fall-through warnings for Clang Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 109/141] net: netrom: " Gustavo A. R. Silva
@ 2020-11-20 18:38 ` Gustavo A. R. Silva
2021-03-04 23:00 ` Gustavo A. R. Silva
2 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2020-11-20 18:38 UTC (permalink / raw)
To: Ralf Baechle, David S. Miller, Jakub Kicinski
Cc: linux-hams, netdev, linux-kernel, linux-hardening,
Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/rose/rose_route.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
index 6e35703ff353..c0e04c261a15 100644
--- a/net/rose/rose_route.c
+++ b/net/rose/rose_route.c
@@ -347,6 +347,7 @@ static int rose_del_node(struct rose_route_struct *rose_route,
case 1:
rose_node->neighbour[1] =
rose_node->neighbour[2];
+ break;
case 2:
break;
}
@@ -508,6 +509,7 @@ void rose_rt_device_down(struct net_device *dev)
fallthrough;
case 1:
t->neighbour[1] = t->neighbour[2];
+ break;
case 2:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 109/141] net: netrom: Fix fall-through warnings for Clang
2020-11-20 18:38 ` [PATCH 109/141] net: netrom: " Gustavo A. R. Silva
@ 2020-11-30 12:51 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-11-30 12:51 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Ralf Baechle, David S. Miller, Jakub Kicinski, linux-hams, netdev,
linux-kernel, linux-hardening
On Fri, Nov 20, 2020 at 12:38:15PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break statements instead of
> letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> net/netrom/nr_route.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
> index 78da5eab252a..de0456073dc0 100644
> --- a/net/netrom/nr_route.c
> +++ b/net/netrom/nr_route.c
> @@ -266,6 +266,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
> fallthrough;
> case 2:
> re_sort_routes(nr_node, 0, 1);
> + break;
> case 1:
> break;
> }
> @@ -359,6 +360,7 @@ static int nr_del_node(ax25_address *callsign, ax25_address *neighbour, struct n
> fallthrough;
> case 1:
> nr_node->routes[1] = nr_node->routes[2];
> + fallthrough;
Make this one a break like the others.
> case 2:
> break;
> }
> @@ -482,6 +484,7 @@ static int nr_dec_obs(void)
> fallthrough;
> case 1:
> s->routes[1] = s->routes[2];
> + break;
> case 2:
> break;
> }
> @@ -529,6 +532,7 @@ void nr_rt_device_down(struct net_device *dev)
> fallthrough;
> case 1:
> t->routes[1] = t->routes[2];
> + break;
> case 2:
> break;
> }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 105/141] net: ax25: Fix fall-through warnings for Clang
2020-11-20 18:37 ` [PATCH 105/141] net: ax25: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-03-04 22:54 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-04 22:54 UTC (permalink / raw)
To: Joerg Reuter, Ralf Baechle, David S. Miller, Jakub Kicinski
Cc: linux-hams, netdev, linux-kernel, linux-hardening
Hi all,
It's been more than 3 months; who can take this, please? :)
Thanks
--
Gustavo
On Fri, Nov 20, 2020 at 12:37:53PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> net/ax25/af_ax25.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index 269ee89d2c2b..2631efc6e359 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
> @@ -850,6 +850,7 @@ static int ax25_create(struct net *net, struct socket *sock, int protocol,
> case AX25_P_ROSE:
> if (ax25_protocol_is_registered(AX25_P_ROSE))
> return -ESOCKTNOSUPPORT;
> + break;
> #endif
> default:
> break;
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 112/141] net: rose: Fix fall-through warnings for Clang
2020-11-20 18:38 ` [PATCH 112/141] net: rose: " Gustavo A. R. Silva
@ 2021-03-04 23:00 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-04 23:00 UTC (permalink / raw)
To: Ralf Baechle, David S. Miller, Jakub Kicinski
Cc: linux-hams, netdev, linux-kernel, linux-hardening
Hi all,
It's been more than 3 months; who can take this, please? :)
Thanks
--
Gustavo
On Fri, Nov 20, 2020 at 12:38:32PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break statements instead of
> letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> net/rose/rose_route.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/rose/rose_route.c b/net/rose/rose_route.c
> index 6e35703ff353..c0e04c261a15 100644
> --- a/net/rose/rose_route.c
> +++ b/net/rose/rose_route.c
> @@ -347,6 +347,7 @@ static int rose_del_node(struct rose_route_struct *rose_route,
> case 1:
> rose_node->neighbour[1] =
> rose_node->neighbour[2];
> + break;
> case 2:
> break;
> }
> @@ -508,6 +509,7 @@ void rose_rt_device_down(struct net_device *dev)
> fallthrough;
> case 1:
> t->neighbour[1] = t->neighbour[2];
> + break;
> case 2:
> break;
> }
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-04 23:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1605896059.git.gustavoars@kernel.org>
2020-11-20 18:37 ` [PATCH 105/141] net: ax25: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-04 22:54 ` Gustavo A. R. Silva
2020-11-20 18:38 ` [PATCH 109/141] net: netrom: " Gustavo A. R. Silva
2020-11-30 12:51 ` Dan Carpenter
2020-11-20 18:38 ` [PATCH 112/141] net: rose: " Gustavo A. R. Silva
2021-03-04 23:00 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).