From: Dan Carpenter <dan.carpenter@oracle.com>
To: Thomas Osterried <thomas@osterried.de>
Cc: linux-hams@vger.kernel.org, Duoming Zhou <duoming@zju.edu.cn>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: Regression in "ax25: Fix UAF bugs in ax25 timers", patch 82e31755e55fbcea6a9dfaae5fe4860ade17cbc0
Date: Mon, 23 May 2022 16:52:14 +0300 [thread overview]
Message-ID: <20220523135214.GE4009@kadam> (raw)
In-Reply-To: <283773C4-71DA-4631-B7B3-19497DA9D77A@osterried.de>
On Mon, May 23, 2022 at 07:46:57AM +0200, Thomas Osterried wrote:
>
> Regression due to patch 82e31755e55fbcea6a9dfaae5fe4860ade17cbc0 "ax25: Fix UAF bugs in ax25 timers",
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/net/ax25/af_ax25.c?id=82e31755e55fbcea6a9dfaae5fe4860ade17cbc0
> and discussion about necessarity of
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/net/ax25/ax25_subr.c?id=fc6d01ff9ef03b66d4a3a23b46fc3c3d8cf92009
> (because it addresses the same problem).
>
>
> Due to patch 82e31755e55fbcea6a9dfaae5fe4860ade17cbc, any ax25 session is cleaned up anymore on disconnect.
> -> netstat --ax25 shows the ex-connected session it in state "LISTEN". Makes ax25 unusable in a production environment.
> => Regression.
Please line wrap your emails at 75 characters.
I tried to apply your patch but the format is wrong... :/
Hopefully Duoming will read this message but the sad truth is that no
one likes to read RFC patches so you'd be better off sending this as
a real patch instead.
regards,
dan carpenter
next prev parent reply other threads:[~2022-05-23 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 5:46 Regression in "ax25: Fix UAF bugs in ax25 timers", patch 82e31755e55fbcea6a9dfaae5fe4860ade17cbc0 Thomas Osterried
2022-05-23 13:52 ` Dan Carpenter [this message]
2022-05-24 9:25 ` Thomas Osterried
2022-05-24 10:47 ` duoming
2022-05-24 21:52 ` Thomas Osterried
2022-05-25 2:34 ` duoming
2022-05-26 22:56 ` Thomas Osterried
2022-05-27 4:48 ` duoming
2022-05-23 14:07 ` duoming
2022-05-23 16:05 ` Roland Schwarz
2022-05-23 18:53 ` Thomas Osterried
2022-05-23 19:14 ` Thomas Osterried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523135214.GE4009@kadam \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=duoming@zju.edu.cn \
--cc=linux-hams@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas@osterried.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox