Re: [PATCH net] ax25: Fix ax25 session cleanup problem in ax25_release

[Jakub Kicinski <kuba@kernel.org>]

On Fri, 27 May 2022 13:29:30 +0200 Thomas Osterried wrote:
> > I Tested several cases: this patch works as expected.  
> If you agree, that no concurrent process is able to re-use this ax25_cb,
> and because all timers are stoppeed, the cleanup with  ax25_cb_del(s);
> should be safe.
> 
> 
> My successfull test was this:
> 
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index 363d47f94532..de417b974c07 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
> @@ -91,6 +92,7 @@ static void ax25_kill_by_device(struct net_device *dev)
>                                 spin_unlock_bh(&ax25_list_lock);
>                                 ax25_disconnect(s, ENETUNREACH);
>                                 s->ax25_dev = NULL;
> +                               ax25_cb_del(s);
>                                 spin_lock_bh(&ax25_list_lock);
>                                 goto again;
>                         }

Thanks a lot for the testing and analysis! We'll give v2 [1] another
day or two on the list and merge it into net.

[1]
https://lore.kernel.org/all/20220527151822.23217-1-duoming@zju.edu.cn/