Re: [PATCH v2] ax25: use GFP_KERNEL in ax25_dev_device_up()

[Dan Carpenter <dan.carpenter@oracle.com>]

On Mon, Jun 06, 2022 at 01:40:12PM -0400, Peter Lafreniere wrote:
> ax25_dev_device_up() is only called during device setup, which is
> done in user context. In addition, ax25_dev_device_up()
> unconditionally calls ax25_register_dev_sysctl(), which already
> allocates with GFP_KERNEL.
> 
> Since it is allowed to sleep in this function, here we change
> ax25_dev_device_up() to use GFP_KERNEL to reduce unnecessary
> out-of-memory errors.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Peter Lafreniere <pjlafren@mtu.edu>
> ---

I don't know if you really want to add Reported-by tags.  That stuff is
just in the kbuild-bot template and it's an automated thing.  Some people
add it and some don't.

It doesn't really matter either way.

> v1 -> v2:
>  - Renamed patch from "ax25: use GFP_KERNEL over GFP_ATOMIC where possible"
>    (Is that okay?)

No problem.

>  - Removed invalid changes to ax25_rt_add()
> 
> This isn't related to the patch itself, but thanks are owed to everyone
> who had to handle my mistakes in submitting this patch the first time.
> First the posting during the merge window, which I know better to do,
> then me making the stupidest error of missing a lock directly next to the
> relevant code.

It's all part of learning.  No stress.  There was no danger because we
caught it in review and automatically with static analysis.

regards,
dan carpenter