Re: 2.6.15 ax25 system lockup with kissattach

[Bernard Pidoux <pidoux@ccr.jussieu.fr>]

Hi Ralf,

Without your patch, running Mandriva Linux 2006 with 2.6.15 kernel on a 
Pentium IV Xeon would freeze immediately when loading mkiss driver.

After the patch was applied and mkiss module compiled and driver 
installed, there is no more problem here.

However, the kernel was compiled with no forced preemption model and 
without SMP option. I will do it soon an report if any change.

Thank you for the nice job you are doing on AX25 stuff.

73 de Bernard, f6bvp

http://f6bvp.free
http://f6bvp.org (mirror)

-----------

Ralf Baechle DL5RB a écrit :
> On Thu, Jan 05, 2006 at 06:26:43PM -0500, Mike McCarthy, W1NR wrote:
> 
> 
>>That's all folks.  System locked up hard.  Caps lock and scroll lock lights
>>flashing.  System needs a hard reset.
>>
>>2.6.14-5 appears to be fine.  Tried recompiled tools and libraries as well.
>>Others report similar problems on Debian systems with 2.6.15 kernel as well.
> 
> 
> Can you try below patch?  It fixes a locking bug which was affecting only
> preemptable or SMP kernels until the recent rewrite of the locking code.
> 
> 73 de DL5RB op Ralf
> 
> --
> Loc. JN47BS / CQ 14 / ITU 28 / DOK A21
> 
>  drivers/net/hamradio/mkiss.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> Index: net.git/drivers/net/hamradio/mkiss.c
> ===================================================================
> --- net.git.orig/drivers/net/hamradio/mkiss.c
> +++ net.git/drivers/net/hamradio/mkiss.c
> @@ -515,6 +515,7 @@ static void ax_encaps(struct net_device 
>  			count = kiss_esc(p, (unsigned char *)ax->xbuff, len);
>  		}
>    	}
> +	spin_unlock_bh(&ax->buflock);
>  
>  	set_bit(TTY_DO_WRITE_WAKEUP, &ax->tty->flags);
>  	actual = ax->tty->driver->write(ax->tty, ax->xbuff, count);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-hams" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html