From: "Mike McCarthy, W1NR" <lists@w1nr.net>
To: Bernard Pidoux <bernard.pidoux@upmc.fr>
Cc: linux-hams <linux-hams@vger.kernel.org>,
Ray Wells <vk2tv@exemail.com.au>,
Charlie k4gbb <k4gbb1@earthlink.net>,
Jerry DeLong <KD4YAL@tampabay.rr.com>, F1TE <f1te@f1te.org>,
f8arr <f8arr@f8arr.org>, Ralf Baechle DL5RB <ralf@linux-mips.org>
Subject: Re: BUGs into libax25
Date: Sun, 01 Jun 2008 22:14:54 -0400 [thread overview]
Message-ID: <4843579E.8030003@w1nr.net> (raw)
In-Reply-To: <4843220B.20703@upmc.fr>
As I recall, there is a limit to the size of a callsign in the AX.25
protocol specification. Will changing it create an incompatibility with
standard TNC protocol stacks?
Mike, W1NR
Bernard Pidoux wrote:
> Hi All,
>
> I found a number of BUGs into libax25 that may affect nearly ALL AX25
> applications for it is in ax25_aton_entry() function that is used to
> translate a callsign into AX25 format.
> Programs like kissattach, listen, ax25ipd, FPAC, xfbbd are concerned.
>
> The code would return an error with 6 letters callsigns.
>
>
> The second set of errors is in /proc/ax25/ timers format description.
> since timers are now in millisec, they require a larger storage size.
> This results in using unsigned long integers rather than unsigned short
> integers.
>
> Ax25-tools and ax25-apps must be recompiled after recompilation and
> installation of this new libax25 version.
> FPAC and LinuxFBB also.
>
> I patched my own source of libax25 and uploaded it here :
>
> http://f6bvp.free.fr/logiciels/ax25/libax25-0.0.11.5src_f6bvp.tgz
>
> Here is the new ChangeLog entry :
>
> libax25 0.0.11.5
> * BUG in axutils.c
> function ax25_aton_entry() was only testing 5 callsign
> characters.
> A lot of ax25-tools and AX25 applications using this library
> function, including FPAC, could have problems with 6 letters
> callsigns. Corrected.
>
> * BUG in proc_ax25 structure timers members size declared in
> procutils.h. Since in kernel 2.6 the timers are now in
> milliseconds,
> they need more place to be saved (unsigned short --> unsigned
> long).
> * corrected, together with functions reading proc files in
> procutils.c.
>
> -- Bernard Pidoux <f6bvp@amsat.org> Jun 1 2008
>
>
> 73 de bernard, f6bvp
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hams" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-06-02 2:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 22:26 BUGs into libax25 Bernard Pidoux
2008-06-02 2:14 ` Mike McCarthy, W1NR [this message]
2008-06-02 6:49 ` Robin Gilks
2008-06-02 9:16 ` Ralf Baechle DL5RB
2008-06-02 17:16 ` Dave Platt
2008-06-02 8:49 ` Ralf Baechle DL5RB
-- strict thread matches above, loose matches on Subject: below --
2008-06-02 9:36 DL5DI
2008-06-02 10:41 ` Matti Aarnio
2008-06-02 16:28 ` Bernard Pidoux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4843579E.8030003@w1nr.net \
--to=lists@w1nr.net \
--cc=KD4YAL@tampabay.rr.com \
--cc=bernard.pidoux@upmc.fr \
--cc=f1te@f1te.org \
--cc=f8arr@f8arr.org \
--cc=k4gbb1@earthlink.net \
--cc=linux-hams@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=vk2tv@exemail.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox