Linux HAM/Amateur Radio development
 help / color / mirror / Atom feed
From: Richard Stearn <richard@rns-stearn.demon.co.uk>
To: linux-hams@vger.kernel.org
Subject: Re: AX.25 in Wireshark (nee Ethereal)
Date: Sat, 10 Apr 2010 10:02:55 +0100	[thread overview]
Message-ID: <4BC03EBF.3010701@rns-stearn.demon.co.uk> (raw)
In-Reply-To: <4BBFA12C.3000002@rns-stearn.demon.co.uk>

Ok, Ok, I am posting in reply to my own post.  A number have asked if 
the patch is being offered to the Wireshark developers, the answer is 
yes but...

I proposed the 2007 patch to the Wireshark developers in 2007 and
it was declined at that time for a number of reasons.

Primarily because the Linux implementation of AX.25 has a "KISS"
header byte thus is not true AX.25 (protocol 3), I had handled
this in the AX.25 dissector. I had done the same with the BPQ
ethernet encapsulation.  So the developers for libpcap, tcpdump
& wireshark declined to accept that patches at that time and in
that form.  I can see their point and do not have a problem with
that point of view.

The libpcap maintainers did add a new protocol
     DLT_AX25_KISS "AX.25 with KISS header"
to libpcap, this went into libpcap late in the 0.9.x series and 
overcomes the problems with having an unidentified protocol to
handle.  I then had to reimplement the dissectors so I had a
KISS dissector that could handle the KISS header and then hand the
encapsulated AX.25 frame on to an AX.25 dissector which in turn can
hand on any encapsulated higher protocol to the appropriate dissector.

Unfortunately I have been involved in family affairs for the last 3
years (the passing of my parents, Mum, Jean G7DKZ and Dad, Bill G0MLT)
so have had no time to follow up on the work.

I have just (in the last week) returned to the issue and have
re-implemented the patch to handle the various "protocols" correctly.
I will be attempting to get the patch accepted by the Wireshark
developers, but in small pieces, not the whole patch as one entity.

Even so parts such as FlexNet, DX cluster & APRS may not be accepted,
FlexNet because I have no spec and the current implementation only
recognises FlexNet rather than doing a detailed dissection, DX cluster
and APRS because they are not protocols, more a way of using the No
Layer 3 protocol PID payload.

I have published this patch so that those who can apply the patch and
recompile can have the benefit while I get the patch into Wireshark
piece by piece.  I can also benefit by the patch being used and hence
the bugs found.

So, please if you can recompile, do so, and use the patch, I no longer
have a working Packet system and thus am dependant on those that do, to
use the code and thus test it.  Also my Packet system was a Linux box,
all my captures are from that system, the code needs to "see" packets
from other systems.

I would also like to know who does recompile to use the patch, so if
you do recompile please drop me an email, via the list or direct, I
do not mind.  Knowing the number who do may be useful when talking to
the Wireshark developers.

-- 
73 de g1sog
	Richard


  reply	other threads:[~2010-04-10  9:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 21:50 AX.25 in Wireshark (nee Ethereal) Richard Stearn
2010-04-10  9:02 ` Richard Stearn [this message]
2010-04-11 20:13 ` IT2 Stuart Blake Tener, USNR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC03EBF.3010701@rns-stearn.demon.co.uk \
    --to=richard@rns-stearn.demon.co.uk \
    --cc=linux-hams@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox