AX25 patches and new FPAC 327.14-pre23 release

AX25 patches and new FPAC 327.14-pre23 release

[Bernard Pidoux]

Hi All,

Ax25 libraries, ax25-apps and ax25-tools available under -rc2 label
have a number of bugs that prevent ROSE network application FPAC to work properly.

List of main bugs in libax25 :
- in /usr/local/include/netax25/procutils.h, use entry is missing  
  in struct proc_rs_neigh
- in procutils.c, ax25_aton_entry(const char *name, char *buf) 
  first while loop is < 6 and should be < 7 to allow checking minus character before SSID
  in six letters callsigns.

In ax25apps, application ax25ipd has been added a dynamic DNS option and more. 
 Read ax25ipd History.  

In ax25tools, a bug in nrattach, prevented initializing NetRom devices.

Patched rc2 source packages are available from here :

http://f6bvp.free.fr/logiciels/ax25/libax25-0.0.12-rc2.patched_f6bvp.tar.bz2
http://f6bvp.free.fr/logiciels/ax25/ax25-apps-0.0.8-rc2.patched_f6bvp.tar.bz2
http://f6bvp.free.fr/logiciels/ax25/ax25-tools-0.0.10-rc2.patched_f6bvp.tar.bz2

A new release of FPAC is also available.
Here are the last version changes :

3.27.14-pre23 (F6BVP)
- Added the following three letters symbolic DNIC list in /etc/ax25/fpac.dnic 
FRA 2080
ESP 2120
USA 3100
CUR 3620
ARU 3630
AUS 5050
NIC 7100
COS 7120
CAN 3020

- When issuing fpacnode command " n * ", the FPAC node list displays an extended node description.
- argument -pthread added in rules.make - Utility ?
- fpacnode was crashing when a connection was attempted to an ax25 callsign identical to a local ax25 port. Corrected
- fpacnode Ports command "p" now displays a more complete list of ax25 ports parameters.
- fpacnode Links command "l" now displays the status of a link : Yes if connected.

FPAC can be bownloaded from here :

http://f6bvp.free.fr/logiciels/rose-fpac/fpac327-14-pre23.tar.bz2

73 de Bernard, f6bvp

Re: AX25 patches and new FPAC 327.14-pre23 release

[Thomas Osterried]

Hello,

On 2010-04-10 19:24:27 +0200, Bernard Pidoux <bernard.pidoux@upmc.fr>
wrote in <4BC0B44B.1060707@upmc.fr>:
> Hi All,
>
> Ax25 libraries, ax25-apps and ax25-tools available under -rc2 label
> have a number of bugs that prevent ROSE network application FPAC to work properly.

Unfortunately, Bernard does not send diffs for patches.
I'd to do it on my own and comment it here.

> List of main bugs in libax25 :
> - in /usr/local/include/netax25/procutils.h, use entry is missing   in 
> struct proc_rs_neigh

fixed in CVS head:

http://www.linux-ax25.org/cvsweb/libax25/netax25/procutils.h.diff?r1=1.1;r2=1.2;f=h

 Revision 1.2: download - view: text, markup, annotated - select for diffs
Thu Nov 26 17:37:41 2009 UTC (4 months, 1 week ago) by dl9sau
Branches: MAIN
CVS tags: HEAD
Diff to: previous 1.1: preferred, colored
Changes since revision 1.1: +20 -19 lines

patch submitted by Bernard Pidoux f6bvp
- in proc_ax25 structure timers members size declared in
  procutils.h. Since in kernel 2.6 the timers are now in milliseconds,
  they need more place to be saved (unsigned short --> unsigned long).
- in procutils.h and procutils.c
  in structure proc_rs_neigh field "use" was missing,
  in function read_proc_rs_neigh proc_rs_neigh use was not read

> - in procutils.c, ax25_aton_entry(const char *name, char *buf)  first 
> while loop is < 6 and should be < 7 to allow checking minus character 
> before SSID
>  in six letters callsigns.

It's not procutils.c but axutils.c.

Your proposed diff is:

+++ libax25-0.0.12-rc2.patched_f6bvp/axutils.c  2010-04-07 22:38:09.000000000 +0200
@@ -24,14 +24,14 @@
        const char *p = name;
        char c;
 
-       while (ct < 6) {
+       while (ct < 7) {
[..]
+       while (ct < 7) {
                buf[ct] = ' ' << 1;
                ct++;
        }

I don't know what your problem was and what it should fix.
But I see, that the while loop has a correct count for a callsign with
a maximum of 6 letters (with "DL9SAU", starting with ct = 0, for
processing "U", ct is = 5 and at the bottom, ct is incremented to 6.
Then it is not < 6 anymore and the while loop is left. This is exactly
the expected behaviour. 

The next while loop fills the rest with shifted blanks for the "buf" in
network-byte-order. buf is sizeof(7); the last position is buf[6] and
contains the SSID. It needs not to be filled with ' ', beause a few lines
later we force it to be assigned, with:
buf[6] = ((ssid + '0') << 1) & 0x1E;

-> I've to reject that patch.

> In ax25apps, application ax25ipd has been added a dynamic DNS option and 
> more. Read ax25ipd History.  

It seems to implement Cathryn's threded-resolving-patch, and others.
I've to look at it deeper. ax25ipd is a "monster".

> In ax25tools, a bug in nrattach, prevented initializing NetRom devices.

Already fixed in CVS head:
http://www.linux-ax25.org/cvsweb/ax25-tools/netrom/nrattach.c.diff?r1=1.3;r2=1.4;f=h

Revision 1.4: download - view: text, markup, annotated - select for diffs
Mon Nov 2 12:24:14 2009 UTC (5 months, 1 week ago) by dl9sau
Branches: MAIN
CVS tags: HEAD
Diff to: previous 1.3: preferred, colored
Changes since revision 1.3: +0 -2 lines

	Fix for a problem I introduced in 2005.
	Thanks to Bernard <f6bvp> for reporting this problem.

> Patched rc2 source packages are available from here :
>
> http://f6bvp.free.fr/logiciels/ax25/libax25-0.0.12-rc2.patched_f6bvp.tar.bz2
> http://f6bvp.free.fr/logiciels/ax25/ax25-apps-0.0.8-rc2.patched_f6bvp.tar.bz2
> http://f6bvp.free.fr/logiciels/ax25/ax25-tools-0.0.10-rc2.patched_f6bvp.tar.bz2

btw, your tar-balls contain directory mode 777. This may cause security
problems.

> 73 de Bernard, f6bvp

73,
	- Thomas  dl9sau

Re: AX25 patches and new FPAC 327.14-pre23 release

[Bernard Pidoux]

Hi Thomas,

I noticed that actual http://www.linux-ax25.org/wiki/Main_Page was back on line :

"2010-03-29 Due to hardware defects the site was running from an outdated copy for a while. 
The problem has been rectified now. Sorry for the inconvenience."

However, the site does not yet reflect the CVS state. 
This is why I had to build patched package for our FPAC node Sysops. 
I did not intend to resend the patches I had already submitted.
This is why I did not send any diff file.
I should have been more clear and I am sorry for the painfull task you had to perform.

I do agree that my axutils.c patch was not necessary.
The error message about "SSID between 0 and 15" was triggered by an application error
in FPAC and made me think the loop was too short, missing minus character.
I was wrong and you were absolutely right to reject the patch.
The error has been already corrected in FPAC.

I understand that ax25ipd is a very complicated application.
Before Cathryn Mataga's last modifications, there was a very useful improvement introduced
as soon as June 2005 by Steve Fraser VK5ASF. He added provision for dynamic dns hosts.
We have been using this for ROSE/FPAC network since. It takes into account nodes without
permanent IPs, when nodes have a dyndns.org or no-ip.org address, without link failure when the
IP address changes suddenly. 
Steve Fraser's patch and the improvements by Cathryn Mataga are constructive
and could be introduced into official ax25-apps package.

Finaly, could you tell me what should be the package directory mode in order to be safe
about security concern ? I would be glad to make the changes on next FPAC delivery.

Many thanks for your help.

73 de Bernard, f6bvp
 

Thomas Osterried a écrit :
> Hello,
> 
> On 2010-04-10 19:24:27 +0200, Bernard Pidoux <bernard.pidoux@upmc.fr>
> wrote in <4BC0B44B.1060707@upmc.fr>:
>> Hi All,
>>
>> Ax25 libraries, ax25-apps and ax25-tools available under -rc2 label
>> have a number of bugs that prevent ROSE network application FPAC to work properly.
> 
> Unfortunately, Bernard does not send diffs for patches.
> I'd to do it on my own and comment it here.
> 
>> List of main bugs in libax25 :
>> - in /usr/local/include/netax25/procutils.h, use entry is missing   in 
>> struct proc_rs_neigh
> 
> fixed in CVS head:
> 
> http://www.linux-ax25.org/cvsweb/libax25/netax25/procutils.h.diff?r1=1.1;r2=1.2;f=h
> 
>  Revision 1.2: download - view: text, markup, annotated - select for diffs
> Thu Nov 26 17:37:41 2009 UTC (4 months, 1 week ago) by dl9sau
> Branches: MAIN
> CVS tags: HEAD
> Diff to: previous 1.1: preferred, colored
> Changes since revision 1.1: +20 -19 lines
> 
> patch submitted by Bernard Pidoux f6bvp
> - in proc_ax25 structure timers members size declared in
>   procutils.h. Since in kernel 2.6 the timers are now in milliseconds,
>   they need more place to be saved (unsigned short --> unsigned long).
> - in procutils.h and procutils.c
>   in structure proc_rs_neigh field "use" was missing,
>   in function read_proc_rs_neigh proc_rs_neigh use was not read
> 
>> - in procutils.c, ax25_aton_entry(const char *name, char *buf)  first 
>> while loop is < 6 and should be < 7 to allow checking minus character 
>> before SSID
>>  in six letters callsigns.
> 
> It's not procutils.c but axutils.c.
> 
> Your proposed diff is:
> 
> +++ libax25-0.0.12-rc2.patched_f6bvp/axutils.c  2010-04-07 22:38:09.000000000 +0200
> @@ -24,14 +24,14 @@
>         const char *p = name;
>         char c;
>  
> -       while (ct < 6) {
> +       while (ct < 7) {
> [..]
> +       while (ct < 7) {
>                 buf[ct] = ' ' << 1;
>                 ct++;
>         }
> 
> I don't know what your problem was and what it should fix.
> But I see, that the while loop has a correct count for a callsign with
> a maximum of 6 letters (with "DL9SAU", starting with ct = 0, for
> processing "U", ct is = 5 and at the bottom, ct is incremented to 6.
> Then it is not < 6 anymore and the while loop is left. This is exactly
> the expected behaviour. 
> 
> The next while loop fills the rest with shifted blanks for the "buf" in
> network-byte-order. buf is sizeof(7); the last position is buf[6] and
> contains the SSID. It needs not to be filled with ' ', beause a few lines
> later we force it to be assigned, with:
> buf[6] = ((ssid + '0') << 1) & 0x1E;
> 
> -> I've to reject that patch.
> 
>> In ax25apps, application ax25ipd has been added a dynamic DNS option and 
>> more. Read ax25ipd History.  
> 
> It seems to implement Cathryn's threded-resolving-patch, and others.
> I've to look at it deeper. ax25ipd is a "monster".
> 
>> In ax25tools, a bug in nrattach, prevented initializing NetRom devices.
> 
> Already fixed in CVS head:
> http://www.linux-ax25.org/cvsweb/ax25-tools/netrom/nrattach.c.diff?r1=1.3;r2=1.4;f=h
> 
> Revision 1.4: download - view: text, markup, annotated - select for diffs
> Mon Nov 2 12:24:14 2009 UTC (5 months, 1 week ago) by dl9sau
> Branches: MAIN
> CVS tags: HEAD
> Diff to: previous 1.3: preferred, colored
> Changes since revision 1.3: +0 -2 lines
> 
> 	Fix for a problem I introduced in 2005.
> 	Thanks to Bernard <f6bvp> for reporting this problem.
> 
>> Patched rc2 source packages are available from here :
>>
>> http://f6bvp.free.fr/logiciels/ax25/libax25-0.0.12-rc2.patched_f6bvp.tar.bz2
>> http://f6bvp.free.fr/logiciels/ax25/ax25-apps-0.0.8-rc2.patched_f6bvp.tar.bz2
>> http://f6bvp.free.fr/logiciels/ax25/ax25-tools-0.0.10-rc2.patched_f6bvp.tar.bz2
> 
> btw, your tar-balls contain directory mode 777. This may cause security
> problems.
> 
>> 73 de Bernard, f6bvp
> 
> 73,
> 	- Thomas  dl9sau
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html