From: Bernard Pidoux <bernard.pidoux@upmc.fr>
To: ralf@linux-mips.org
Cc: linux-hams@vger.kernel.org, Bernard Pidoux <bernard.pidoux@upmc.fr>
Subject: Can ROSE socket debug message be removed ?
Date: Tue, 21 Dec 2010 11:41:59 +0100 [thread overview]
Message-ID: <4D108477.4060108@upmc.fr> (raw)
In-Reply-To: <4CF78B70.4060907@free.fr>
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
Hi Ralf,
The same question about removing the following ROSE
kernel debug messages that fills /var/log/kernel/info and does not
seem to be actually usefull.
Should the SOCK_DEBUG lines be commented or removed ?
Bernard Pidoux <f6bvp@free.fr>
[-- Attachment #2: af_rose_sock_debug.patch --]
[-- Type: text/x-patch, Size: 1535 bytes --]
--- a/net/rose/af_rose.c 2010-12-19 12:12:57.712847187 +0100
+++ b/net/rose/af_rose.c 2010-12-09 20:03:57.557563800 +0100
@@ -716,7 +739,7 @@
rose_insert_socket(sk);
sock_reset_flag(sk, SOCK_ZAPPED);
- SOCK_DEBUG(sk, "ROSE: socket is bound\n");
+/* SOCK_DEBUG(sk, "ROSE: socket is bound\n");*/
return 0;
}
@@ -1113,10 +1138,10 @@
srose.srose_digis[n] = rose->dest_digis[n];
}
- SOCK_DEBUG(sk, "ROSE: sendto: Addresses built.\n");
+/* SOCK_DEBUG(sk, "ROSE: sendto: Addresses built.\n");*/
/* Build a packet */
- SOCK_DEBUG(sk, "ROSE: sendto: building packet.\n");
+/* SOCK_DEBUG(sk, "ROSE: sendto: building packet.\n");*/
/* Sanity check the packet size */
if (len > 65535)
return -EMSGSIZE;
@@ -1131,7 +1156,7 @@
/*
* Put the data on the end
*/
- SOCK_DEBUG(sk, "ROSE: Appending user data\n");
+/* SOCK_DEBUG(sk, "ROSE: Appending user data\n");*/
skb_reset_transport_header(skb);
skb_put(skb, len);
@@ -1156,7 +1181,7 @@
*/
asmptr = skb_push(skb, ROSE_MIN_LEN);
- SOCK_DEBUG(sk, "ROSE: Building Network Header.\n");
+/* SOCK_DEBUG(sk, "ROSE: Building Network Header.\n");*/
/* Build a ROSE Network header */
asmptr[0] = ((rose->lci >> 8) & 0x0F) | ROSE_GFI;
@@ -1166,9 +1191,9 @@
if (qbit)
asmptr[0] |= ROSE_Q_BIT;
- SOCK_DEBUG(sk, "ROSE: Built header.\n");
+/* SOCK_DEBUG(sk, "ROSE: Built header.\n");*/
- SOCK_DEBUG(sk, "ROSE: Transmitting buffer\n");
+/* SOCK_DEBUG(sk, "ROSE: Transmitting buffer\n");*/
if (sk->sk_state != TCP_ESTABLISHED) {
kfree_skb(skb);
prev parent reply other threads:[~2010-12-21 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 12:05 [PATCH] [ROSE] AX25 packet routing improvement f6bvp
2010-12-20 18:11 ` f6bvp
2011-01-21 11:23 ` f6bvp
2010-12-21 10:38 ` Can AX25 socket debug message be removed ? f6bvp
2010-12-21 17:33 ` Ralf Baechle DL5RB
2010-12-22 9:43 ` Bernard Pidoux F6BVP
2011-02-15 14:25 ` f6bvp
2010-12-21 10:41 ` Bernard Pidoux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D108477.4060108@upmc.fr \
--to=bernard.pidoux@upmc.fr \
--cc=linux-hams@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox