From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] net ax25: Fix the build when sysctl support is disabled. Date: Mon, 23 Apr 2012 18:28:45 -0700 Message-ID: <4F9601CD.2070000@xenotime.net> References: <20120423170701.c96e402234b1387dece11dda@canb.auug.org.au> <4F95828A.8050403@xenotime.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenotime.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=kwlpY8biSA98hquk6zUR/mmy/AA4iOTRrMa6yjqO+zE=; b=nCpDBaZpyoTq6Kv0pTiyJC8OJUsgvyCY+VZdsyqHARHYLg9diEZO788zg33MnKt5ThyHc7FlNUi3kFmsFCz8w3G4xbydsDRtF6C92XTaFX6yVw3QHF3RSQlnpKjpXvwd; In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: "Eric W. Biederman" Cc: David Miller , Stephen Rothwell , linux-next@vger.kernel.org, LKML , netdev@vger.kernel.org, linux-hams@vger.kernel.org, Ralf Baechle On 04/23/2012 05:25 PM, Eric W. Biederman wrote: > > Randy Dunlap reported: > >> On 04/23/2012 12:07 AM, Stephen Rothwell wrote: >> >>> Hi all, >>> >>> Changes since 20120420: >> >> >> include/net/ax25.h:447:75: error: expected ';' before '}' token >> >> static inline int ax25_register_dev_sysctl(ax25_dev *ax25_dev) { return 0 }; >> static inline void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev) {}; >> >> First function: move ';' inside braces. >> Second function: drop the ';'. > > Put the semicolons where it makes sense. > > Signed-off-by: Eric W. Biederman Acked-by: Randy Dunlap Thanks. > --- > > Resent to include David Miller. > > include/net/ax25.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/net/ax25.h b/include/net/ax25.h > index 8a7a122..5d23521 100644 > --- a/include/net/ax25.h > +++ b/include/net/ax25.h > @@ -444,8 +444,8 @@ extern void ax25_uid_free(void); > extern int ax25_register_dev_sysctl(ax25_dev *ax25_dev); > extern void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev); > #else > -static inline int ax25_register_dev_sysctl(ax25_dev *ax25_dev) { return 0 }; > -static inline void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev) {}; > +static inline int ax25_register_dev_sysctl(ax25_dev *ax25_dev) { return 0; } > +static inline void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev) {} > #endif /* CONFIG_SYSCTL */ > > #endif -- ~Randy