Linux HAM/Amateur Radio development
 help / color / mirror / Atom feed
From: Cathryn Mataga <cathryn@junglevision.com>
To: Thomas Osterried <thomas@x-berg.in-berlin.de>
Cc: linux-hams <linux-hams@vger.kernel.org>
Subject: Netrom:  Quality issue
Date: Sat, 06 Jul 2013 23:08:02 -0700	[thread overview]
Message-ID: <51D905C2.1000301@junglevision.com> (raw)
In-Reply-To: <20130706202807.GB18314@x-berg.in-berlin.de>

This code is in both your 0.0.8 and 0.0.10

It compares the quality and then afterwards it decreases the value

         if (best_quality < port_list[index].worst_qual) {
                 if (debug && logging)
                         syslog(LOG_DEBUG, "netromr: add_node: quality 
less than worst_qual");
                 return FALSE;
         }

         nr_node->quality = ((quality * best_quality) + 128) / 256;


Err, I don't think it's really a bug.  He's probably got a node coming 
in at quality 120 and then it does (120 * 120 +128)/256 Maybe update the 
man page to explain what's going on.

               worstqual     this is the worst quality node received 
from a routing broadcast that will be added
                             to our routing table.


  parent reply	other threads:[~2013-07-07  6:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-06  4:19 Netrom on kernel version 3.9.6-200 Cathryn Mataga
2013-07-06  4:43 ` Cathryn Mataga
2013-07-06  5:33   ` Cathryn Mataga
2013-07-06  5:42     ` Cathryn Mataga
2013-07-06 17:24       ` David Ranch
2013-07-06 18:32         ` Cathryn Mataga
2013-07-06 20:28         ` Thomas Osterried
2013-07-07  5:49           ` Cathryn Mataga
2013-07-07  6:08           ` Cathryn Mataga [this message]
2013-07-07 16:59             ` Netrom: Quality issue David Ranch
2013-07-07 18:45               ` Cathryn Mataga
2013-07-08  3:40                 ` David Ranch
2013-07-08  3:49                   ` Cathryn Mataga
2013-07-08  7:48                     ` Thomas Osterried
2013-07-08 13:24                       ` Cathryn Mataga
  -- strict thread matches above, loose matches on Subject: below --
2013-07-07 18:36 Brian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D905C2.1000301@junglevision.com \
    --to=cathryn@junglevision.com \
    --cc=linux-hams@vger.kernel.org \
    --cc=thomas@x-berg.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox