* [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()
[not found] <cover.1434501120.git.luto@kernel.org>
@ 2015-06-17 0:35 ` Andy Lutomirski
2015-06-17 0:49 ` Thomas Sailer
2015-06-20 13:54 ` walter harms
0 siblings, 2 replies; 6+ messages in thread
From: Andy Lutomirski @ 2015-06-17 0:35 UTC (permalink / raw)
To: x86
Cc: Borislav Petkov, Peter Zijlstra, John Stultz, linux-kernel,
Len Brown, Huang Rui, Denys Vlasenko, kvm, Ralf Baechle,
Andy Lutomirski, walter harms, Thomas Sailer, linux-hams
This is only used if BAYCOM_DEBUG is defined.
Cc: walter harms <wharms@bfs.de>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Thomas Sailer <t.sailer@alumni.ethz.ch>
Cc: linux-hams@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
I'm hoping for an ack for this to go through -tip.
drivers/net/hamradio/baycom_epp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
index 83c7cce0d172..44e5c3b5e0af 100644
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -638,7 +638,7 @@ static int receive(struct net_device *dev, int cnt)
#define GETTICK(x) \
({ \
if (cpu_has_tsc) \
- rdtscl(x); \
+ x = (unsigned int)native_read_tsc(); \
})
#else /* __i386__ */
#define GETTICK(x)
--
2.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()
2015-06-17 0:35 ` [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc() Andy Lutomirski
@ 2015-06-17 0:49 ` Thomas Sailer
2015-06-20 13:54 ` walter harms
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Sailer @ 2015-06-17 0:49 UTC (permalink / raw)
To: Andy Lutomirski, x86
Cc: Borislav Petkov, Peter Zijlstra, John Stultz, linux-kernel,
Len Brown, Huang Rui, Denys Vlasenko, kvm, Ralf Baechle,
walter harms, linux-hams
Acked-by: Thomas Sailer <t.sailer@alumni.ethz.ch>
On 06/17/2015 02:35 AM, Andy Lutomirski wrote:
> This is only used if BAYCOM_DEBUG is defined.
>
> Cc: walter harms <wharms@bfs.de>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Thomas Sailer <t.sailer@alumni.ethz.ch>
> Cc: linux-hams@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>
> I'm hoping for an ack for this to go through -tip.
>
> drivers/net/hamradio/baycom_epp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
> index 83c7cce0d172..44e5c3b5e0af 100644
> --- a/drivers/net/hamradio/baycom_epp.c
> +++ b/drivers/net/hamradio/baycom_epp.c
> @@ -638,7 +638,7 @@ static int receive(struct net_device *dev, int cnt)
> #define GETTICK(x) \
> ({ \
> if (cpu_has_tsc) \
> - rdtscl(x); \
> + x = (unsigned int)native_read_tsc(); \
> })
> #else /* __i386__ */
> #define GETTICK(x)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()
2015-06-17 0:35 ` [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc() Andy Lutomirski
2015-06-17 0:49 ` Thomas Sailer
@ 2015-06-20 13:54 ` walter harms
2015-06-20 14:14 ` Thomas Gleixner
1 sibling, 1 reply; 6+ messages in thread
From: walter harms @ 2015-06-20 13:54 UTC (permalink / raw)
To: Andy Lutomirski
Cc: x86, Borislav Petkov, Peter Zijlstra, John Stultz, linux-kernel,
Len Brown, Huang Rui, Denys Vlasenko, kvm, Ralf Baechle,
Thomas Sailer, linux-hams
Acked-by: walter harms <wharms@bfs.de>
Am 17.06.2015 02:35, schrieb Andy Lutomirski:
> This is only used if BAYCOM_DEBUG is defined.
>
> Cc: walter harms <wharms@bfs.de>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Thomas Sailer <t.sailer@alumni.ethz.ch>
> Cc: linux-hams@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>
> I'm hoping for an ack for this to go through -tip.
>
> drivers/net/hamradio/baycom_epp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
> index 83c7cce0d172..44e5c3b5e0af 100644
> --- a/drivers/net/hamradio/baycom_epp.c
> +++ b/drivers/net/hamradio/baycom_epp.c
> @@ -638,7 +638,7 @@ static int receive(struct net_device *dev, int cnt)
> #define GETTICK(x) \
> ({ \
> if (cpu_has_tsc) \
> - rdtscl(x); \
> + x = (unsigned int)native_read_tsc(); \
> })
> #else /* __i386__ */
> #define GETTICK(x)
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()
2015-06-20 13:54 ` walter harms
@ 2015-06-20 14:14 ` Thomas Gleixner
2015-06-20 14:26 ` Andy Lutomirski
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2015-06-20 14:14 UTC (permalink / raw)
To: walter harms
Cc: Andy Lutomirski, x86, Borislav Petkov, Peter Zijlstra,
John Stultz, linux-kernel, Len Brown, Huang Rui, Denys Vlasenko,
kvm, Ralf Baechle, Thomas Sailer, linux-hams
On Sat, 20 Jun 2015, walter harms wrote:
> Acked-by: walter harms <wharms@bfs.de>
>
> Am 17.06.2015 02:35, schrieb Andy Lutomirski:
> > This is only used if BAYCOM_DEBUG is defined.
So why don't we just replace that by ktime_get() and get rid of the
x86'ism in that driver.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()
2015-06-20 14:14 ` Thomas Gleixner
@ 2015-06-20 14:26 ` Andy Lutomirski
2015-06-20 16:30 ` Thomas Gleixner
0 siblings, 1 reply; 6+ messages in thread
From: Andy Lutomirski @ 2015-06-20 14:26 UTC (permalink / raw)
To: Thomas Gleixner
Cc: walter harms, Andy Lutomirski, X86 ML, Borislav Petkov,
Peter Zijlstra, John Stultz, linux-kernel@vger.kernel.org,
Len Brown, Huang Rui, Denys Vlasenko, kvm list, Ralf Baechle,
Thomas Sailer, linux-hams
On Sat, Jun 20, 2015 at 7:14 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sat, 20 Jun 2015, walter harms wrote:
>
>> Acked-by: walter harms <wharms@bfs.de>
>>
>> Am 17.06.2015 02:35, schrieb Andy Lutomirski:
>> > This is only used if BAYCOM_DEBUG is defined.
>
> So why don't we just replace that by ktime_get() and get rid of the
> x86'ism in that driver.
>
I don't have the hardware, and I don't see any good reason to make an
rdtsc cleanup depend on a more complicated driver change. On the
other hand, if the maintainers want to clean it up, I think it would
be a great idea.
This really seems to be debugging code, though. A normal kernel won't
even compile it.
--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()
2015-06-20 14:26 ` Andy Lutomirski
@ 2015-06-20 16:30 ` Thomas Gleixner
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2015-06-20 16:30 UTC (permalink / raw)
To: Andy Lutomirski
Cc: walter harms, Andy Lutomirski, X86 ML, Borislav Petkov,
Peter Zijlstra, John Stultz, linux-kernel@vger.kernel.org,
Len Brown, Huang Rui, Denys Vlasenko, kvm list, Ralf Baechle,
Thomas Sailer, linux-hams
On Sat, 20 Jun 2015, Andy Lutomirski wrote:
> On Sat, Jun 20, 2015 at 7:14 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Sat, 20 Jun 2015, walter harms wrote:
> >
> >> Acked-by: walter harms <wharms@bfs.de>
> >>
> >> Am 17.06.2015 02:35, schrieb Andy Lutomirski:
> >> > This is only used if BAYCOM_DEBUG is defined.
> >
> > So why don't we just replace that by ktime_get() and get rid of the
> > x86'ism in that driver.
> >
>
> I don't have the hardware, and I don't see any good reason to make an
> rdtsc cleanup depend on a more complicated driver change. On the
> other hand, if the maintainers want to clean it up, I think it would
> be a great idea.
>
> This really seems to be debugging code, though. A normal kernel won't
> even compile it.
Right, but there is no reason that we have rdtsc outside of arch/x86
at all.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-20 16:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1434501120.git.luto@kernel.org>
2015-06-17 0:35 ` [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc() Andy Lutomirski
2015-06-17 0:49 ` Thomas Sailer
2015-06-20 13:54 ` walter harms
2015-06-20 14:14 ` Thomas Gleixner
2015-06-20 14:26 ` Andy Lutomirski
2015-06-20 16:30 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).