From: walter harms <wharms@bfs.de>
To: Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: linux-kernel@vger.kernel.org, linux-hams@vger.kernel.org
Subject: Re: [PATCH v05 69/72] uapi rose.h: glibc netrose/rose.h header file compatibility fixes
Date: Sun, 28 Aug 2016 14:37:41 +0200 [thread overview]
Message-ID: <57C2DB15.3050103@bfs.de> (raw)
In-Reply-To: <20160828055918.GZ5399@lakka.kapsi.fi>
Am 28.08.2016 07:59, schrieb Mikko Rapeli:
> On Fri, Aug 26, 2016 at 05:38:00PM +0200, walter harms wrote:
>> perhaps this not tested snipped would make sure that
>> you have included linux/rose.h ?
>>
>> #ifndef ROSE_KERNEL_H
>> #include <linux/rose.h>
>> #endif
>>
>> #include <netrose/rose.h>
>
> Sorry, I did not quite get this.
>
> <linux/rose.h> has conflicting definitions with glibc <netrose/rose.h>.
> The patches fixes the uapi headers <linux/rose.h> so that it hides
> definitions if <netrose/rose.h> from glibc was already included.
>
> -Mikko
no problem,
so far i understand the conflict arise because you need to include
linux/rose.h before netrose/rose.h
My suggestion was to add a check for linux/rose.h (ROSE_KERNEL_H)
and include it if not already done. (basicly this should work out
of the box but it seems a problem here).
I have no idea if you need to cover other cases but in my
understanding userspace programms should not include kernel headers.
re,
wh
next prev parent reply other threads:[~2016-08-28 12:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi>
2016-08-22 18:33 ` [PATCH v05 68/72] uapi ax25.h: glibc netax25/ax25.h header file compatibility fixes Mikko Rapeli
2016-08-22 23:33 ` David Miller
[not found] ` <20160822.163303.1956681667227236700.davem@davemloft.net>
2016-08-23 21:21 ` [PATCH v05 66/72] uapi icmp.h: glibc netinet/ip_icmp.h " Mikko Rapeli
2016-08-23 23:38 ` David Miller
2016-08-22 18:33 ` [PATCH v05 69/72] uapi rose.h: glibc netrose/rose.h " Mikko Rapeli
2016-08-22 23:33 ` David Miller
2016-08-26 15:38 ` walter harms
2016-08-28 5:59 ` Mikko Rapeli
2016-08-28 12:37 ` walter harms [this message]
2016-08-29 19:34 ` David Ranch
2016-08-30 7:34 ` Mikko Rapeli
2016-11-16 19:07 ` Mikko Rapeli
2016-11-16 22:17 ` David Ranch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C2DB15.3050103@bfs.de \
--to=wharms@bfs.de \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.rapeli@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox