From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jakub Kicinski <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
ast-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org
Cc: bpf-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org,
johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
luiz.dentz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jgg-uk2M96/98Pc@public.gmane.org,
mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
ap420073-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org,
woojung.huh-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
andrew-g2DYL2Zd6BY@public.gmane.org,
vivien.didelot-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
george.mccollister-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
michael.chan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
jesse.brandeburg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
anthony.l.nguyen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hawk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
john.fastabend-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
tariqt-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
saeedm-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
ecree.xilinx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
habetsm.xilinx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jreuter-K7Hl1MveuGQ@public.gmane.org,
dsahern-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
pkshih-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org,
trond.myklebust-F/q8l9xzQnoyLce1RVWEUA@public.gmane.org,
anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org,
viro-RmSDqhL/yNOoGNRTaapkhg@public.gmane.org
Subject: Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
Date: Tue, 28 Dec 2021 17:33:39 -0800 [thread overview]
Message-ID: <5a82690c-7dc0-81de-4dd6-06e26e4b9b92@gmail.com> (raw)
In-Reply-To: <20211229004913.513372-1-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On 12/28/2021 4:49 PM, Jakub Kicinski wrote:
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
>
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
>
> Acked-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Signed-off-by: Jakub Kicinski <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Acked-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
It would be nice if we used the number of files rebuilt because of a
header file change as another metric that the kernel is evaluated with
from release to release (or even on a commit by commit basis). Food for
thought.
--
Florian
next prev parent reply other threads:[~2021-12-29 1:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 0:49 [PATCH bpf-next v2] net: don't include filter.h from net/sock.h Jakub Kicinski
[not found] ` <20211229004913.513372-1-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2021-12-29 1:33 ` Florian Fainelli [this message]
2021-12-29 17:20 ` Jakub Kicinski
2022-01-04 15:42 ` Andy Shevchenko
2021-12-29 11:46 ` Nikolay Aleksandrov
2021-12-29 14:05 ` Stefano Garzarella
2021-12-29 16:51 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a82690c-7dc0-81de-4dd6-06e26e4b9b92@gmail.com \
--to=f.fainelli-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=anthony.l.nguyen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ap420073-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ast-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=bpf-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dsahern-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ecree.xilinx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=george.mccollister-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=habetsm.xilinx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hawk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=jesse.brandeburg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=john.fastabend-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jreuter-K7Hl1MveuGQ@public.gmane.org \
--cc=kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=luiz.dentz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=michael.chan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olteanv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=pkshih-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org \
--cc=saeedm-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=tariqt-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=trond.myklebust-F/q8l9xzQnoyLce1RVWEUA@public.gmane.org \
--cc=viro-RmSDqhL/yNOoGNRTaapkhg@public.gmane.org \
--cc=vivien.didelot-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
--cc=woojung.huh-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox