public inbox for linux-hams@vger.kernel.org
 help / color / mirror / Atom feed
From: Ashutosh Desai <ashutoshdesai993@gmail.com>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, linux-hams@vger.kernel.org,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rose: fix OOB reads on short CLEAR REQUEST frames
Date: Tue, 14 Apr 2026 23:03:32 -0700 (PDT)	[thread overview]
Message-ID: <69df2a34.050a0220.2d53f.b61c@mx.google.com> (raw)
In-Reply-To: <CANn89iLXG5ZMNeHkcLW+Ug9PxNnw_EKtpGVkPw1qeXEjJNtA0g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Hi Eric,

On Mon, Apr 13, 2026 at 11:11 PM Eric Dumazet wrote:
> rose_process_rx_frame() callers already call kfree_skb(skb) if
> rose_process_rx_frame() returns a 0. Your patch would add double-frees.
>
> Your patch is white-space mangled.

Thanks for the review. Sent v3 with all issues addressed.

Best regards,
Ashutosh

  reply	other threads:[~2026-04-15  6:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14  6:04 [PATCH v2] rose: fix OOB reads on short CLEAR REQUEST frames Ashutosh Desai
2026-04-14  6:11 ` Eric Dumazet
2026-04-15  6:03   ` Ashutosh Desai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-09  7:08 [PATCH] ax25: fix OOB read after address header strip in ax25_rcv() Eric Dumazet
2026-04-09 15:19 ` [PATCH v2] rose: fix OOB reads on short CLEAR REQUEST frames Ashutosh Desai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69df2a34.050a0220.2d53f.b61c@mx.google.com \
    --to=ashutoshdesai993@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox