From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 137801D543 for ; Fri, 3 May 2024 20:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714768606; cv=none; b=sqTvMg9EhBLlo34MdDyUKzoDl/nnHVAGSXkjgFeVMiaCzBG56sj74xnrB71jdgaT1+hgdTgc2dP9CqqqfdMU5pazATGOj/Q7nKkdjfF2WrW8IXQYOtFeP7+ijckY2sW1eE3LN1XtO6iU+fs6M8QEJXGuD3/L+pC/8WLnnJDT864= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714768606; c=relaxed/simple; bh=FBZMACvGRXJqMeLEDzDUFBkDEnHe6DAU3slqqPNPaqg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sAI0TV7FSlLswoJvQUU8pHSQZ87gKlQqMgmUYDCpIu7KAQnXSW/rSDK3ke4U1+bDvj7qCp4LmsVZbQQAyByXr0UH0PlbRSNWL6DRVMZNi5MrADEwNF4gTqWAxn2gVUIf6u8610MQ6MRHGBt1yb6h7HIdxuts4DkBN0B95cslAN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GD6O8Hin; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GD6O8Hin" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41b5e74fa2fso1357145e9.1 for ; Fri, 03 May 2024 13:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714768601; x=1715373401; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SOGaco3fXlUM58da9nIuO+b/VVWLgaUOQsvu5003Nmw=; b=GD6O8HinHuMJbamq0ke8yQHFLrkso1UKNXelni7YFcwZ4nHMKCTOFHFx+XSo/YwT7e rIUmuZNa9lZp16ToKr/BqFDOTVsa1pkFY+jRARlqd+7fBCQ8FaUluobC9FLIK6U9TS3d X4aGYYXpy+GDgZVMVfeoA3omLI4MYAXeD8PjzvcLsQjK6INcpdEBwyg6HQg42qsuGYxD GhkUfV04sTBhtErjBeY4sVI43bd8hqtpSjDkJwnOm/0fWIC6ssBAgw1vyDw87+h/Yxw3 tlUffhKU1rMfVz8ULC4hA54CXAXF7p7ybtHEy64U9xE6YcSdpCFtgcRdABGaH+zK6phw +TKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714768601; x=1715373401; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SOGaco3fXlUM58da9nIuO+b/VVWLgaUOQsvu5003Nmw=; b=EsQVINysz9Xyi0xY/1y80O7tQFp0TpyYrxxlDMmKWcJPrq1SXVYy6I+6VjZMlt5iGv rH43OAo2Jkan2xAPTbFpqrEKwF+iMvBm8f2PEAMy2Ew+BW2qCrzDCNCNCoBI2N8Pgryw g9BQPKGb6/HNCdU5WSA4EPIMcX51YeTys9X93Vp+jqdCklQUEeGGnWtmJGuUegYZZ5Ct Z7Vla13Xd6dRZ61iGUcIMM7C5AWYNvBBDb3dzVhwa0vnlHs5JZuTb83XOTm5Y1Ok3H/J W7f0afkCLF0CeQ8eIgZz4CVlUUX3ySrUj2vKlxLtFQVoJxOPSX7opZs5oV7fjrc9dDdC IBbA== X-Forwarded-Encrypted: i=1; AJvYcCXnLnhLn5yw3Ccxw04gdmzndOCu8EmU2P6tNuggv50NRhivnZQTJGhaqv7G91jqS90EXNLdiB8J3ECSkRHL9exCSrNWPYyrUKNSsw== X-Gm-Message-State: AOJu0Yytw1V9WX8tSLfkq+BZ6kXM7GN77oVzWzO8UtCICwDit0Q6jjJf 69Wrx2Bcy1ZeSJ5mkXOtX6PSuV3JyBM5pakqdM3HkWszu2nuoRAGCMskcr57gtQ= X-Google-Smtp-Source: AGHT+IHT1ANwaQtrF/f0AcbUmuzqU9zPw45kPKXJTTCYO6bMPHHy7X3ECjv7drf3rYFms81bZXcA/g== X-Received: by 2002:a05:600c:1d26:b0:418:e88b:92c3 with SMTP id l38-20020a05600c1d2600b00418e88b92c3mr3068178wms.2.1714768601152; Fri, 03 May 2024 13:36:41 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id r9-20020a05600c35c900b0041bf5b9fb93sm6826049wmq.5.2024.05.03.13.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 13:36:40 -0700 (PDT) Date: Fri, 3 May 2024 23:36:37 +0300 From: Dan Carpenter To: Lars Kellogg-Stedman Cc: Duoming Zhou , linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, jreuter@yaina.de Subject: Re: [PATCH net] ax25: Fix refcount leak issues of ax25_dev Message-ID: <78ae8aa0-eac5-4ade-8e85-0479a22e98a3@moroto.mountain> References: <20240501060218.32898-1-duoming@zju.edu.cn> Precedence: bulk X-Mailing-List: linux-hams@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Could you test this diff? regards, dan carpenter diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 558e158c98d0..a7f96a4ceff4 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -1129,8 +1129,10 @@ static int ax25_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) /* * User already set interface with SO_BINDTODEVICE */ - if (ax25->ax25_dev != NULL) + if (ax25->ax25_dev != NULL) { + ax25_dev_hold(ax25->ax25_dev); goto done; + } if (addr_len > sizeof(struct sockaddr_ax25) && addr->fsa_ax25.sax25_ndigis == 1) { if (ax25cmp(&addr->fsa_digipeater[0], &null_ax25_address) != 0 &&