From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF613346AD for ; Thu, 4 Dec 2025 10:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764842666; cv=none; b=C65u0Mug4ze7TKkZjk0sNxX4soKxDiMdW/ryELhxbw7jDKG2ldijGNG4bq83lYulKC7RDgubeGla5Qp80DCxWWPygxNkm92CRSVt3NKMsouQldO62j4pTG2emkuzPVp7Zlo2dfEE7E0dGJow8tpRwAYxsSijlqnmtyQMnRXD+dA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764842666; c=relaxed/simple; bh=NkGy5Yxav+hxu5WxRgjThmTZ5m0bK0FqnEpQGAWdXWE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MH7NTXuZnjjk0+fOpji+/je4od9oR7zN4PlEGGZWWp3UHqUU7+IxjM0PlLei3JnQOwRWGRbcz6Z3aqUH6wY3+nVKEK2Btk0QLaDL0Q8fJ0FId0B9xUw9dKh07s7ZiBOR53cW0sFUut/8HN1c3Nrcsq7sZwkaV5bfmfHxlwYRINc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M+AMVUJw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Eg/kfJ0A; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M+AMVUJw"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Eg/kfJ0A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764842663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jYJIwmIzAHmgYcwAHqAyW0oXzjS8vsesR3EEDMcroX8=; b=M+AMVUJwwnn0MKy5C5ipE7/VqA78EtA4u/Wk2e31fgDnyyNyyA6gJ+ZKX5agLHZHAUIlZJ n28WGpxBLdnA/Bs3egE0qz1gDJcdGhCcZr+pfN3CXQwVWSMRuz5JzErrRtYdiv5FDNS6Th 770AMl8kZd1jnMTAMiPGCxxchS6hHik= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-wOQdH_yoPc-sBtIlbv0hAA-1; Thu, 04 Dec 2025 05:04:22 -0500 X-MC-Unique: wOQdH_yoPc-sBtIlbv0hAA-1 X-Mimecast-MFC-AGG-ID: wOQdH_yoPc-sBtIlbv0hAA_1764842661 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4776079ada3so5976585e9.1 for ; Thu, 04 Dec 2025 02:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764842661; x=1765447461; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jYJIwmIzAHmgYcwAHqAyW0oXzjS8vsesR3EEDMcroX8=; b=Eg/kfJ0ALXJT/PXWpmHyLdK3n13XQ4cMgMCzjWcG7f7wYXua3Wm2Y3tB5hXu+Oub1L xopAsZUysi2IwFWePLtNOeCQ/wRyJGo0eNAO+10emZ9i3VxKGouN6STizy3RvBKa3oHl C4fP3m9DPjmmGvtYzvAfNVTRzSknVOqAjsxdRCkPnzi7ook6xWGHNoUWrjQYWQDoazcY gVdE2vz0XZmFbakCwydGXPdrHfFB7ciLYwelZs7AV9WAhb7CqOG7Q7zFDtSHlFJ7JR1K 6gUPsaYQ2/ruGTJQuqTRgwnryUh3nKF2PLDD/To1RuvJSWcRHaLvVUdNlm6EsbMvdkKf 0SzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764842661; x=1765447461; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jYJIwmIzAHmgYcwAHqAyW0oXzjS8vsesR3EEDMcroX8=; b=lp8+cVQNfDwPbEhOQlNP0/9737IdCojE0M27aAHigubKe7bxSd9Nq2+qK2bLuNj2V7 VlIuSQhTvkCXWO+nYWA5Xid4vnVqvFDCtt+iqGStF+Kchx900AKYgjO00q/96G6FQ10U BOFNKAMhcwgR8iU8x6owmHbpQTxaRLYc9hirt45qwXLdrS/+kUPn1xDL5fTqmJOgOHcN t3utNeBW7tArR0H7AtxW47OlRE8hrFw8YGuFVO8lwyHfczrGUjRWAtNdPGR5MqLglMI1 6R7orDxAbRuK/gXEwlMzu4u1num4K0dIbMItKFAYK/V2e64JfohPzgiKJFVt+Vm2QYKU S+Cw== X-Gm-Message-State: AOJu0YwAow7dl5M9IVgNZGNAYp7zS4zoCztsJ3CoxxWUassrPpIMK9uc jpRAdIWgxfBiGNeFCHXCcShQyhVchLA+fvr1HPyEVIyoOUhQUIIxXsRHKFWJPsyoO5r7DpJhT0d SAWODyhrqJWHazzis3B/+GQ63Ig+OR/L2sVB7dsEAbZysHs5LO1txA83fgZezPEL4vC2UY7Q= X-Gm-Gg: ASbGncsrhpbxQRSWphxp4At0hGCzjFzmVtZwtsIS2wiMxZdVzEKLqPV20/no3NhlGsT ABQ9AAwD+jFpeYRBjSYGypC0FQNqJJgkxU5Yrd50shnksl8eUM7ZynA8vfUEtLcwPGPoFrF1qO3 uul0csA2UwFpoYdqBZJ2lRNIG7yVtC4Y/pBR2BOM5JjzW8yTJBHS9L3eQ6VUC36hOe/xpStbj3q UCM5MUQgGx51uh8UOAbCWh9NhLAEkL21h7L5DWnrtHuePo2k7nz7nOd0x/2jRUEpLPi0tkuDgXg 1opoeyRXnvAM+MyXBEb5uadgf7wrZukfM4tpBUT4ZdB8t2pwmWoQuLjhn/MH8tufwwlcJ6N/+12 RwqTv9OzID+sM X-Received: by 2002:a05:600c:3b1f:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-4792f386f92mr20088135e9.20.1764842661074; Thu, 04 Dec 2025 02:04:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHtlgpbU3wPzpHckIiNG7MkxJnSSWwzko1ByQE61szhPF3nugo4abw7JPrLtUp1XhZD817+Jg== X-Received: by 2002:a05:600c:3b1f:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-4792f386f92mr20087785e9.20.1764842660674; Thu, 04 Dec 2025 02:04:20 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792b12411fsm42744815e9.3.2025.12.04.02.04.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 02:04:20 -0800 (PST) Message-ID: <7bea2244-dc28-4c67-b515-739b8b7d7901@redhat.com> Date: Thu, 4 Dec 2025 11:04:18 +0100 Precedence: bulk X-Mailing-List: linux-hams@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: netrom: fix memory leak in nr_output() To: Wang Liang , Deepanshu Kartikey , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+d7abc36bbbb6d7d40b58@syzkaller.appspotmail.com References: <20251129034232.405203-1-kartikey406@gmail.com> <17e41b73-3497-4ea0-b91c-4710514f7b14@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <17e41b73-3497-4ea0-b91c-4710514f7b14@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/29/25 5:01 AM, Wang Liang wrote: > 在 2025/11/29 11:42, Deepanshu Kartikey 写道: >> When nr_output() fragments a large packet, it calls sock_alloc_send_skb() > > Hi! > > Coincidentally, we both are working on this issue simultaneously. > > From the syz test requests: > https://syzkaller.appspot.com/bug?extid=d7abc36bbbb6d7d40b58 > > I sended the test patch earlier, only a dozen seconds... FTR and future similar cases, we don't have the send time information handy. Instead we use the timestamp as available on patchwork. In this specific case Deepanshu's patch landed first, but does not apply cleanly, so I'll apply Wang's one. Cheers, Paolo