public inbox for linux-hardening@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: platform-driver-x86@vger.kernel.org,
	Rosen Penev <rosenp@gmail.com>,
	 Kenneth Chan <kenneth.t.chan@gmail.com>,
	Hans de Goede <hansg@kernel.org>,  Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	 LKML <linux-kernel@vger.kernel.org>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCHv2] platform/x86: panasonic-laptop: simplify allocation of sinf
Date: Tue, 31 Mar 2026 18:44:44 +0300 (EEST)	[thread overview]
Message-ID: <0e92b09e-3fe3-16bd-d6c2-bb7e0dcf2094@linux.intel.com> (raw)
In-Reply-To: <ee68ff4e-27b5-4373-86dc-3b7a5ad7f7b5@embeddedor.com>

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

On Tue, 31 Mar 2026, Gustavo A. R. Silva wrote:

> 
> 
> On 3/31/26 09:02, Ilpo Järvinen wrote:
> > On Wed, 25 Mar 2026 19:45:25 -0700, Rosen Penev wrote:
> > 
> > > Change to a flexible array member to allocate once instead of twice.
> > > 
> > > Allows using __counted_by for extra runtime analysis. Move the counting
> > > variable assignment to right after allocation as required by
> > > __counted_by.
> 
> This is misinformation and should be phrased differently[1]

Okay. I'll drop the patch for now.

--
 i.

> 
> -Gustavo
> 
> [1]
> https://lore.kernel.org/linux-hardening/37378f49-437f-438b-ad6c-d60480feb306@embeddedor.com/
> 
> > > 
> > > Remove + 1 to allocation. It's already done in the previous line.
> > > 
> > > [...]
> > 
> > 
> > Thank you for your contribution, it has been applied to my local
> > review-ilpo-next branch. Note it will show up in the public
> > platform-drivers-x86/review-ilpo-next branch only once I've pushed my
> > local branch there, which might take a while.
> > 
> > The list of commits applied:
> > [1/1] platform/x86: panasonic-laptop: simplify allocation of sinf
> >        commit: e75869527c720c4ed1458cfbe25e92186950e43a
> > 
> > --
> >   i.
> > 
> > 
> 

      reply	other threads:[~2026-03-31 15:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  2:45 [PATCHv2] platform/x86: panasonic-laptop: simplify allocation of sinf Rosen Penev
2026-03-31 15:02 ` Ilpo Järvinen
2026-03-31 15:26   ` Gustavo A. R. Silva
2026-03-31 15:44     ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e92b09e-3fe3-16bd-d6c2-bb7e0dcf2094@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=gustavo@embeddedor.com \
    --cc=gustavoars@kernel.org \
    --cc=hansg@kernel.org \
    --cc=kees@kernel.org \
    --cc=kenneth.t.chan@gmail.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox