From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1683715FCED for ; Thu, 11 Jul 2024 16:16:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.202.169.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720714583; cv=none; b=GZ+2Auh90Qt3X6nwRGmVLc9xdQkdwjKBWhvOm/BzfBn1NkjN1TnXNIb3TODHQotsu38niSVGa8mPejl3mRBQRWnGJ5hsoayRDz/UVHB4cJd3R6yTfUMzJnuBuZgNCU0wP6G2XG/+okmyDpErmFd4IwUXS7ZSqu5XCaZdfRuuNWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720714583; c=relaxed/simple; bh=YcA+H0UH5himzWlQiVV55SJZ5aod/NYeqs8LnRg02Fk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y3798vGOHbTuzTSS9q5KFUrAf0kQ/Ymm+lQJ+6VT41zCAFZEwbPpexe3KxExkJGABb9UjTtWlwHYKOgGbTy/maYk06xlIlYo+28MnR/GQsWmwCuUa700pzKmcWjUZILL/2stWV90ZCLi5g39jiz4cIRnD08Bc1U+0sNzNVAELk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com; spf=pass smtp.mailfrom=embeddedor.com; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b=0JUsBAUG; arc=none smtp.client-ip=44.202.169.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedor.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="0JUsBAUG" Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id RcXJsjTvyg2lzRwSysK5bC; Thu, 11 Jul 2024 16:16:20 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id RwSxsyyUTJYlLRwSxsHlCv; Thu, 11 Jul 2024 16:16:19 +0000 X-Authority-Analysis: v=2.4 cv=CKIsXwrD c=1 sm=1 tr=0 ts=66900553 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=frY+GlAHrI6frpeK1MvySw==:17 a=IkcTkHD0fZMA:10 a=4kmOji7k6h8A:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=Q-fNiiVtAAAA:8 a=bLk-5xynAAAA:8 a=yPCof4ZbAAAA:8 a=rOUgymgbAAAA:8 a=Gf48L2LQQ7vtOYgXLocA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Fp8MccfUoT0GBdDC_Lng:22 a=zSyb8xVVt2t83sZkrLMb:22 a=MP9ZtiD8KjrkvI0BhSjB:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eQeYix7fsBclpcHIxpnFNByXsSZl5xwa42J/v4FFhmc=; b=0JUsBAUG0QHvvmEIoymFjkBgBt F9Sp0DNoKYz8c6svYFTkIBAOlHGODEWnpMHO52iJf6FjWYZ5CFq40WcahCEmv1xsboMnD2XYdSBmU AKP+LtQcWfl32Kxi5VOXrJp5uTMAFAyloA6KTCgFMPnzLABRziiSqwYVtCpQShA7TH+nV4yeuV6KV N06vXjYAo3JWtFZ5BKx9ws+NpZWRiDctTi3oMKLY8T4TZwDeff30clF0i9hZ8sDsrBCi9b/mATl4Z sRofDOWnhB2OrE5nJFnZuS9PXTAEG5v96r6sUYng6pTx5L9h97tbLRA3sY9u7cWM93P44E5nDOir+ +9Um89Dg==; Received: from [201.172.173.139] (port=38138 helo=[192.168.15.4]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1sRwSv-004Hk8-16; Thu, 11 Jul 2024 11:16:17 -0500 Message-ID: <15be9ec9-02a1-452d-aee5-d6536eef6796@embeddedor.com> Date: Thu, 11 Jul 2024 10:16:15 -0600 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] scsi: mpi3mr: struct mpi3_event_data_sas_topology_change_list: Replace 1-element array with flexible array To: Kees Cook , Sathya Prakash Veerichetty Cc: Kashyap Desai , Sumit Saxena , Sreekanth Reddy , "James E.J. Bottomley" , "Martin K. Petersen" , "Gustavo A. R. Silva" , Ranjan Kumar , Stephen Rothwell , mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240711155446.work.681-kees@kernel.org> <20240711155637.3757036-1-kees@kernel.org> Content-Language: en-US From: "Gustavo A. R. Silva" In-Reply-To: <20240711155637.3757036-1-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 201.172.173.139 X-Source-L: No X-Exim-ID: 1sRwSv-004Hk8-16 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.15.4]) [201.172.173.139]:38138 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 2 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNY/JQ0aLoUDaQKKBBHj7Mn760JDod5ilZv/KOTHAUaUtm+ACKfDrSjq7qyH0RvpgLgPAk4izfDu5Avie+XAFOVfot+sy3px+/oz2suOdmfVEL7EUuhg zzIyYiWoJaRUknUHJlQMAM/H/BVnBkISZvwHGp4WvjMReQ/Qu8SyE4raDp2WRW0cKLHueJ0YnlGwlt5xVDaACT1G4gI9PthMkFj5x/7nitFHeAJ3ty9o2wgI On 11/07/24 09:56, Kees Cook wrote: > Replace the deprecated[1] use of a 1-element array in > struct mpi3_event_data_sas_topology_change_list with a modern > flexible array. > > Additionally add __counted_by annotation since phy_entry is only ever > accessed in loops controlled by num_entries. For example: > > for (i = 0; i < event_data->num_entries; i++) { > ... > handle = le16_to_cpu(event_data->phy_entry[i].attached_dev_handle); > > No binary differences are present after this conversion. > > Link: https://github.com/KSPP/linux/issues/79 [1] > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > Cc: Sathya Prakash Veerichetty > Cc: Kashyap Desai > Cc: Sumit Saxena > Cc: Sreekanth Reddy > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: "Gustavo A. R. Silva" > Cc: Ranjan Kumar > Cc: Stephen Rothwell > Cc: mpi3mr-linuxdrv.pdl@broadcom.com > Cc: linux-scsi@vger.kernel.org > Cc: linux-hardening@vger.kernel.org > --- > drivers/scsi/mpi3mr/mpi/mpi30_ioc.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/scsi/mpi3mr/mpi/mpi30_ioc.h b/drivers/scsi/mpi3mr/mpi/mpi30_ioc.h > index 028784949873..ae74fccc65b8 100644 > --- a/drivers/scsi/mpi3mr/mpi/mpi30_ioc.h > +++ b/drivers/scsi/mpi3mr/mpi/mpi30_ioc.h > @@ -453,9 +453,6 @@ struct mpi3_event_data_sas_notify_primitive { > #define MPI3_EVENT_NOTIFY_PRIMITIVE_POWER_LOSS_EXPECTED (0x02) > #define MPI3_EVENT_NOTIFY_PRIMITIVE_RESERVED1 (0x03) > #define MPI3_EVENT_NOTIFY_PRIMITIVE_RESERVED2 (0x04) > -#ifndef MPI3_EVENT_SAS_TOPO_PHY_COUNT > -#define MPI3_EVENT_SAS_TOPO_PHY_COUNT (1) > -#endif > struct mpi3_event_sas_topo_phy_entry { > __le16 attached_dev_handle; > u8 link_rate; > @@ -496,7 +493,7 @@ struct mpi3_event_data_sas_topology_change_list { > u8 start_phy_num; > u8 exp_status; > u8 io_unit_port; > - struct mpi3_event_sas_topo_phy_entry phy_entry[MPI3_EVENT_SAS_TOPO_PHY_COUNT]; > + struct mpi3_event_sas_topo_phy_entry phy_entry[] __counted_by(num_entries); > }; > > #define MPI3_EVENT_SAS_TOPO_ES_NO_EXPANDER (0x00)