From: Kees Cook <keescook@chromium.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: laniel_francis@privacyrequired.com,
linux-hardening@vger.kernel.org, davem@davemloft.net
Subject: Re: [RFC][PATCH v2 0/3] Fix inefficiences and rename nla_strlcpy
Date: Mon, 19 Oct 2020 15:58:36 -0700 [thread overview]
Message-ID: <202010191557.C2653B0A@keescook> (raw)
In-Reply-To: <20201019094515.46db8af1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Oct 19, 2020 at 09:45:15AM -0700, Jakub Kicinski wrote:
> On Mon, 19 Oct 2020 17:23:28 +0200 laniel_francis@privacyrequired.com
> wrote:
> > To sum up, the first patch fixes an inefficiency where some bytes in dst were
> > written twice, one with 0 the other with src content.
> > The second one modifies nla_strlcpy to return the same value as strscpy,
> > i.e. number of bytes written or -E2BIG if src was truncated.
> > The third rename nla_strlcpy to nla_strcpy.
> >
> > Unfortunately, I did not find how to create struct nlattr objects so I tested
> > my modifications on simple char*.
> > This is why I tag this patch set as RFC.
> >
> > If you see any way to improve the code or have any remark, feel free to comment.
>
> You follow semantics of strscpy, yet rename to strcpy. Wouldn't it be
> more intuitive for developers to rename to nla_strscpy?
It's closer to strscpy_pad() but that seems a long name. What's
preferred from the NLA perspective?
--
Kees Cook
next prev parent reply other threads:[~2020-10-19 22:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 12:52 [RFC][PATCH v1] Fix and rename nla_strlcpy to nla_strcpy laniel_francis
2020-10-16 12:52 ` [PATCH v1 1/3] Fix unefficient call to memset before memcpu in nla_strlcpy laniel_francis
2020-10-16 23:19 ` Kees Cook
2020-10-17 8:50 ` Francis Laniel
2020-10-16 23:29 ` Jann Horn
2020-10-17 8:50 ` Francis Laniel
2020-10-16 12:52 ` [PATCH v1 2/3] Modify return value of nla_strlcpy to match that of strscpy laniel_francis
2020-10-16 23:23 ` Kees Cook
2020-10-17 8:53 ` Francis Laniel
2020-10-17 0:41 ` Jann Horn
2020-10-17 8:56 ` Francis Laniel
2020-10-16 12:52 ` [PATCH v1 3/3] Rename nla_strlcpy to nla_strcpy laniel_francis
2020-10-16 23:18 ` Kees Cook
2020-10-19 15:23 ` [RFC][PATCH v2 0/3] Fix inefficiences and rename nla_strlcpy laniel_francis
2020-10-19 15:23 ` [RFC][PATCH v2 1/3] Fix unefficient call to memset before memcpu in nla_strlcpy laniel_francis
2020-10-19 15:23 ` [RFC][PATCH v2 2/3] Modify return value of nla_strlcpy to match that of strscpy laniel_francis
2020-10-19 16:43 ` Jakub Kicinski
2020-10-19 23:01 ` Kees Cook
2020-10-19 23:34 ` Jakub Kicinski
2020-10-20 10:28 ` Francis Laniel
2020-10-20 17:23 ` Kees Cook
2020-10-20 17:19 ` Kees Cook
2020-10-20 13:05 ` Francis Laniel
2020-10-20 10:17 ` Francis Laniel
2020-10-19 15:23 ` [RFC][PATCH v2 3/3] Rename nla_strlcpy to nla_strcpy laniel_francis
2020-10-19 16:45 ` [RFC][PATCH v2 0/3] Fix inefficiences and rename nla_strlcpy Jakub Kicinski
2020-10-19 22:58 ` Kees Cook [this message]
2020-10-19 23:34 ` Jakub Kicinski
2020-10-20 10:18 ` Francis Laniel
2020-10-19 23:03 ` Kees Cook
2020-10-20 13:06 ` Francis Laniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010191557.C2653B0A@keescook \
--to=keescook@chromium.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-hardening@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox