Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

Josh Poimboeuf
2021-03-04T00:52:20Z

On Wed, Mar 03, 2021 at 02:24:12PM -0600, Josh Poimboeuf wrote:
> On Wed, Mar 03, 2021 at 11:57:33AM -0800, Linus Torvalds wrote:
> > On Wed, Mar 3, 2021 at 11:38 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > >
> > > > But in the meantime, making the plugins depend on the gcc version some
> > > > way is certainly better than not doing so.
> > >
> > > So currently, the plugins already so that. They require the GCC version
> > > to be exact. If there's a mismatch, then it fails the OOT module build.
> >
> > That's not my experience.
> >
> > Yes, the build fails, but it fails not by _rebuilding_, but by failing
> > with an error.
>
> Um, that's what I said. It does not rebuild. It fails with an error.
>
> The *proposal* is to rebuild the plugin -- which Masahiro nacked because
> he claims GCC mismatches aren't supported for OOT builds (plugin or
> not).
>
> Your nack is for a different reason: GCC plugins are second-class
> citizens. Fair enough...

Or was it a nack? :-) Reading your message again, I may have
misinterpreted. Put simply, should we rebuild plugins when the GCC
version changes?

--
Josh