From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58567C43331 for ; Thu, 4 Mar 2021 00:52:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4133F64FCF for ; Thu, 4 Mar 2021 00:52:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241354AbhCDAvg (ORCPT ); Wed, 3 Mar 2021 19:51:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29214 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388038AbhCCUd0 (ORCPT ); Wed, 3 Mar 2021 15:33:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614803519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rp8C696QhKx8WEsv8npjzvCJHKF8U4KwqfIW0LL6UTo=; b=Pi6r3i72j7HR3ZrAoy9duVv3/4e57Br+IeG+iJZ+AzncZ3r7fK6xrP/rJl9H5m0i1/pyQF zaxugn4zH/9CG0/EkPumQ6eKUPjmFJ9IbkBeXG2eq88VmzlhGyT0bFtLJh+VRPhinR8oF4 8eX66NvjcE0sg25Arz8xXVBR2dLmu4g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-ExOu-U9oO0eSbnF6gui41A-1; Wed, 03 Mar 2021 15:31:58 -0500 X-MC-Unique: ExOu-U9oO0eSbnF6gui41A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42B5C514A; Wed, 3 Mar 2021 20:31:56 +0000 (UTC) Received: from treble (ovpn-114-218.rdu2.redhat.com [10.10.114.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A645360BFA; Wed, 3 Mar 2021 20:31:53 +0000 (UTC) Date: Wed, 3 Mar 2021 14:31:50 -0600 From: Josh Poimboeuf To: Linus Torvalds Cc: Masahiro Yamada , Linux Kernel Mailing List , Michal Marek , linux-hardening@vger.kernel.org, Linux Kbuild mailing list , Peter Zijlstra , Justin Forbes , Ondrej Mosnacek , Frank Eigler , Kees Cook Subject: Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules Message-ID: <20210303203150.jwupthv6siil6tn2@treble> References: <20210302232649.y2tutffhxsblwqlb@treble> <20210303191516.6ksxmng4pis7ue4p@treble> <20210303193806.oovupl4ubtkkyiih@treble> <20210303202406.bxgdx5a25j6wc43b@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210303202406.bxgdx5a25j6wc43b@treble> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Wed, Mar 03, 2021 at 02:24:12PM -0600, Josh Poimboeuf wrote: > On Wed, Mar 03, 2021 at 11:57:33AM -0800, Linus Torvalds wrote: > > On Wed, Mar 3, 2021 at 11:38 AM Josh Poimboeuf wrote: > > > > > > > But in the meantime, making the plugins depend on the gcc version some > > > > way is certainly better than not doing so. > > > > > > So currently, the plugins already so that. They require the GCC version > > > to be exact. If there's a mismatch, then it fails the OOT module build. > > > > That's not my experience. > > > > Yes, the build fails, but it fails not by _rebuilding_, but by failing > > with an error. > > Um, that's what I said. It does not rebuild. It fails with an error. > > The *proposal* is to rebuild the plugin -- which Masahiro nacked because > he claims GCC mismatches aren't supported for OOT builds (plugin or > not). > > Your nack is for a different reason: GCC plugins are second-class > citizens. Fair enough... Or was it a nack? :-) Reading your message again, I may have misinterpreted. Put simply, should we rebuild plugins when the GCC version changes? -- Josh