* [PATCH] drm/i915/display: Do not zero past infoframes.vsc
@ 2021-06-17 21:33 Kees Cook
0 siblings, 0 replies; only message in thread
From: Kees Cook @ 2021-06-17 21:33 UTC (permalink / raw)
To: Jani Nikula
Cc: Kees Cook, stable, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Ville Syrjälä, Imre Deak, Ankit Nautiyal,
Manasi Navare, Uma Shankar, José Roberto de Souza,
Lucas De Marchi, Sean Paul, Gwan-gyeong Mun, linux-kernel,
intel-gfx, dri-devel, linux-hardening
intel_dp_vsc_sdp_unpack() was using a memset() size (36, struct dp_sdp)
larger than the destination (24, struct drm_dp_vsc_sdp), clobbering
fields in struct intel_crtc_state after infoframes.vsc. Use the actual
target size for the memset().
Fixes: 1b404b7dbb10 ("drm/i915/dp: Read out DP SDPs")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 5c9222283044..6cc03b9e4321 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2868,7 +2868,7 @@ static int intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
if (size < sizeof(struct dp_sdp))
return -EINVAL;
- memset(vsc, 0, size);
+ memset(vsc, 0, sizeof(*vsc));
if (sdp->sdp_header.HB0 != 0)
return -EINVAL;
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-17 21:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-17 21:33 [PATCH] drm/i915/display: Do not zero past infoframes.vsc Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).