From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C74C433F5 for ; Wed, 3 Nov 2021 18:40:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AAB0610E7 for ; Wed, 3 Nov 2021 18:40:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbhKCSnC (ORCPT ); Wed, 3 Nov 2021 14:43:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229893AbhKCSnB (ORCPT ); Wed, 3 Nov 2021 14:43:01 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 279C7C061205 for ; Wed, 3 Nov 2021 11:40:25 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id r28so3169813pga.0 for ; Wed, 03 Nov 2021 11:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fnS1heGGb0+muHckszGySqCIwOaFpB98WMOnGGOqVKg=; b=mEUUXJmD9IPgrcEV0fG8lr2QecKZsk9r5va8PT/HM3PQC0IP3ZgmcyX98lZFfOJj5/ aJtbR1VV82hV/qbOtprJNFzANIy0qLQ8xpGjlEfbW9QvAsHFQiUiZnRSNuMq0ac4PSQZ 0/PfJOwnqMHc30Rq1LXaa4KbNerYBDvAmmIvc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fnS1heGGb0+muHckszGySqCIwOaFpB98WMOnGGOqVKg=; b=YgzeDJuGZc5MdRTCuZ/Gkoej6DnPfwyKqMWH1kJIJMzIiYfS5wyMuaR8a2W717jtn2 rzcXp9iANROur8ajUufnDFpDwKG/CNCIbycez4ku1gvSiBff4wjo9eNY2onVQLIohhjq enro4XW1iQ2EfNPk6Y+cZn0Z7Tauh1ulx/W9xjOzJ6a4RPWC/BMnnVvYOoLko8vN94dM EHMgaSIzSxY/pIiwbTQPGTbcoCmwi7yHujL0Ayy1eINaPEuioZFDhC6A5N9n6JC9LX2E moRxEAQcrTh/LfRXr+N7kKF+sd9QxV2OGmBnx6nNZ5d+lefoF3PKQSoSOBAg+CusjQdw cz2A== X-Gm-Message-State: AOAM531s9v2ZxA1dhWPKM4fDkv4Reljzf32CeIJsovs9LnogLVWMCpvS Je6G+SPyuenuyZfrL8CLeptkCQ== X-Google-Smtp-Source: ABdhPJzp+ITq0OXvsRnDmkAnKuQZj8sZcIVhXXsgU0yOJeK6eluHRAzpXUU0NDQsHX7Jsb8XD104Mg== X-Received: by 2002:a63:3d8f:: with SMTP id k137mr35119137pga.21.1635964824700; Wed, 03 Nov 2021 11:40:24 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 17sm3181541pfp.14.2021.11.03.11.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 11:40:24 -0700 (PDT) Date: Wed, 3 Nov 2021 11:40:23 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: Andy Lutomirski , Will Drewry , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/2] selftests/seccomp: Report event mismatches more clearly Message-ID: <202111031139.80CE97C532@keescook> References: <20211103163039.2104830-1-keescook@chromium.org> <87lf253x1c.fsf@disp2133> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lf253x1c.fsf@disp2133> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Wed, Nov 03, 2021 at 01:37:51PM -0500, Eric W. Biederman wrote: > Kees Cook writes: > > > Hi, > > > > This expands the seccomp selftests slightly to add additional debug > > reporting detail and a new "immediate fatal SIGSYS under tracing" test. > > I expect to be taking these via my seccomp tree. > > Acked-by: "Eric W. Biederman" > > I am a little fuzzy on the details but I understand what and why > you are testing (I broken it). So this is my 10,000 foot ack. Thanks! Yeah, and the other tests did catch it, but it was kind of a "side effect", so I added the specific "direct" case where it can be seen more clearly. -- Kees Cook