From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E57FFC77B7C for ; Wed, 10 May 2023 19:24:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231803AbjEJTYm (ORCPT ); Wed, 10 May 2023 15:24:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbjEJTYl (ORCPT ); Wed, 10 May 2023 15:24:41 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D300F1BB for ; Wed, 10 May 2023 12:24:39 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1aad6f2be8eso71501625ad.3 for ; Wed, 10 May 2023 12:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683746679; x=1686338679; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=HXHY5peLySfKV7fD6H1ijt1olAC50bP9lGE3KVhNLQg=; b=OI0aC+/AEAMnd83LFI8Aag6udSJxYUe+70XR+T/z67fLGkrTod0pjrlql618r+gvqx MfuO8oonl8fVsdJ+f+WQ4arWAtwK8c/6z+qrZvix2Vh05m2QjIWoVs5Sl0fTRTBCPCfl kZQXXzaXVoWrhYFa80roLq9Q2Id2j6Yv55LBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683746679; x=1686338679; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HXHY5peLySfKV7fD6H1ijt1olAC50bP9lGE3KVhNLQg=; b=OIYra6Tb07YFlfWquwdh/h3MIowWJsyY/hXPuTF4ShDoLTBmIKIulPEr50T/LkweZ7 RdmXvFZ14APK1290p6A279ANqYdYWZdceDr8lxKxv+5qqAopD+y1whyWlxgx4dBNM3id mMwq9/2L9LKbYoIYEWkwL82O8HE+s1a+sopgaHZE1raMaqiyhPdghiCMCtXQs4o0GBoj XHt1T+5Ohp7327gZSqdt4m9DZOEOJw5WyASsriNLgx5Z72GmwuZ2T+DjUnGp16Veaozu kS4pwfq06gbJTvDbtM5bVmDwy5CyiimjsJ/BqILuMZErVtLo/u1bRfdDDWJzb2TAVtvc 7uOQ== X-Gm-Message-State: AC+VfDzArpA9Y/QI0KLnfuBwCPvRx0CbvqkfosZWB/teg9cpOhBcKDvu Nar/cUccD6aup8/W6kcktXf26Q== X-Google-Smtp-Source: ACHHUZ5CF7fA3Kqg/UxBd853ruj1Tzn0GgcCvZUFaYGJR4zX/wzc7t2kMAj1WEzPP7kw9FfgfS/0Aw== X-Received: by 2002:a17:902:e84d:b0:1ab:eee:c609 with SMTP id t13-20020a170902e84d00b001ab0eeec609mr23964108plg.40.1683746679344; Wed, 10 May 2023 12:24:39 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id u17-20020a170903125100b001aafe4f9b8esm4163639plh.180.2023.05.10.12.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 12:24:38 -0700 (PDT) Date: Wed, 10 May 2023 12:24:38 -0700 From: Kees Cook To: Nick Desaulniers Cc: linux-hardening@vger.kernel.org, Andy Shevchenko , Cezary Rojewski , Puyou Lu , Mark Brown , Josh Poimboeuf , Peter Zijlstra , Brendan Higgins , David Gow , Andrew Morton , Nathan Chancellor , Alexander Potapenko , Zhaoyang Huang , Randy Dunlap , Geert Uytterhoeven , Miguel Ojeda , Alexander Lobakin , Liam Howlett , Vlastimil Babka , Dan Williams , Rasmus Villemoes , Yury Norov , "Jason A. Donenfeld" , Sander Vanheule , Eric Biggers , "Masami Hiramatsu (Google)" , Andrey Konovalov , Linus Walleij , Daniel Latypov , =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [PATCH v2 01/10] kunit: tool: Enable CONFIG_FORTIFY_SOURCE under UML Message-ID: <202305101223.B940A881@keescook> References: <20230407191904.gonna.522-kees@kernel.org> <20230407192717.636137-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Fri, Apr 07, 2023 at 04:42:27PM -0700, Nick Desaulniers wrote: > On Fri, Apr 7, 2023 at 4:33 PM Nick Desaulniers wrote: > > > > On Fri, Apr 7, 2023 at 12:27 PM Kees Cook wrote: > > > > > > Since commit ba38961a069b ("um: Enable FORTIFY_SOURCE"), it's possible > > > to run the FORTIFY tests under UML. Enable CONFIG_FORTIFY_SOURCE when > > > running with --altests to gain additional coverage, and by default under > > > > two L's in alltest? > > Also, while testing this series: > ``` > $ LLVM=1 ./tools/testing/kunit/kunit.py run > ... > [16:40:09] ================== fortify (24 subtests) =================== > [16:40:09] [PASSED] known_sizes_test > [16:40:09] [PASSED] control_flow_split_test > [16:40:09] [PASSED] alloc_size_kmalloc_const_test > [16:40:09] # alloc_size_kmalloc_dynamic_test: EXPECTATION FAILED > at lib/fortify_kunit.c:249 > [16:40:09] Expected __builtin_dynamic_object_size(p, 1) == expected, but > [16:40:09] __builtin_dynamic_object_size(p, 1) == -1 > (0xffffffffffffffff) > [16:40:09] expected == 11 (0xb) > [16:40:09] __alloc_size() not working with __bdos on kmemdup("hello > there", len, gfp) I'm still tracking this down. I'm not sure what's happening here, but it seems to be Clang-specific, and due to some interaction with the changes I made for Kunit examination. WHY it happens I haven't found yet. -- Kees Cook