From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A72CC678DF for ; Thu, 17 Aug 2023 23:41:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232987AbjHQXkh (ORCPT ); Thu, 17 Aug 2023 19:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356140AbjHQXk1 (ORCPT ); Thu, 17 Aug 2023 19:40:27 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FA7730DF for ; Thu, 17 Aug 2023 16:40:26 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1bf1935f6c2so2570375ad.1 for ; Thu, 17 Aug 2023 16:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692315626; x=1692920426; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1VCakgqASg3h9183qTuhRoaN+EGRR2UwJM9N77vDLR8=; b=JImyrb2e/StN5NZPwiXTxfSJ8H055CDGNgN8XmqgLAwHdgHkLjLl8nifuytazbaktR KVHi6Mjmxj4tA1TCxWnCf+IZFMrYPeX7quUzVyy4S0WUMnz967Gnwbu61lexaYJ4BJnm JJQfrx1t/if1DjKRFaShzkrdejZxfqgN7prIk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692315626; x=1692920426; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1VCakgqASg3h9183qTuhRoaN+EGRR2UwJM9N77vDLR8=; b=NR3OiFXrpl/9nvN0KHtt5g8yb2xGRYbG+Z7oDUpn575sAoai9CyDw/QxUxWgRUXSEP mN4VIEgTbR2UJ945FBd5qlTfeJeZ3t43kIIS+72RsOmni0sjao+MbZyobtZ0/jA2cdvF O7UjoH75HZmVtnbZf98m5cvP6qvKUrm2zdkbe2sXYIlW4gMB8vxBLU6VSfl012zWPi/U eRgUlbvT4y9k2uMNukqKWVisboWQ3xX7+QndI+LiiGrzsXec9Vw7mubDJ4aCzUgTchRI YTnFp0wBoxtXjAqZK3rLocY8q5LICo2QERHz33o/oxs/AZ4iN53bp6Pbnk0xLJexlbWN 1XcA== X-Gm-Message-State: AOJu0Yw/mmTfP5Dx7beSukOtyFE7TsitpKUS6jYg3BFp9kOiqzY3WLuj C9vIvdGerTSz5Z3zZyEEyFjrNQ== X-Google-Smtp-Source: AGHT+IFPQt+NcgencYztvbHc+KfKgXvjSMi+thjcbfvjb/04TPsE7lu5R6RUGJ6v3UpZfG1jcgsgYQ== X-Received: by 2002:a17:902:e807:b0:1ba:fe6a:3845 with SMTP id u7-20020a170902e80700b001bafe6a3845mr966877plg.11.1692315625977; Thu, 17 Aug 2023 16:40:25 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 19-20020a170902c11300b001afd821c057sm336599pli.58.2023.08.17.16.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 16:40:25 -0700 (PDT) Date: Thu, 17 Aug 2023 16:40:24 -0700 From: Kees Cook To: Yuxiao Zhang Cc: Tony Luck , "'Guilherme G . Piccoli'" , Greg KH , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, wak@google.com Subject: Re: [PATCH] pstore: ramoops: support pmsg size larger than kmalloc limitation Message-ID: <202308171639.B97420B5@keescook> References: <20230630205358.3601280-1-yuxiaozhang@google.com> <20230718202347.3320812-1-yuxiaozhang@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718202347.3320812-1-yuxiaozhang@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Tue, Jul 18, 2023 at 01:23:47PM -0700, Yuxiao Zhang wrote: > Friendly ping, any update on this? Hi! I finally got a chance to look this over. I added a few more kvzalloc() uses to generalize this for all records (not just pmsg), and it's testing well. Here's the resulting commit: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/pstore&id=104fd0b5e948157f8e8ac88a20b46ba8641d4e95 -- Kees Cook